[202012][fast-reboot] Remove FLEX_COUNTER_TABLE from config_db.json b… #1774
Conversation
| # Remove FLEX_COUNTER_TABLE from config_db.json | ||
| # This is done so that in fast-reboot recovery path, FLEX_COUNTER polling is delayed. | ||
| # Delayed FLEX_COUNTER polling is an attempt keep dataplane downtime below 30s threshold | ||
| jq --indent 4 'del(.FLEX_COUNTER_TABLE)' ${CONFIG_DB_FILE} > ${CONFIG_DB_FILE}.new |
There was a problem hiding this comment.
How do we restore the config, if use has made some configs?
There was a problem hiding this comment.
For branches (201811, 201911, 202012):
The user changed configuration to FLEX_COUNTER_TABLE will be reset. This is acceptable so far as for the upgrades, we anyway delete the /host/old_config/config_db.json file (basically removing all of the old config, and letting new image take the default config).
For newer branches (2021**):
Below PRs are targeted to address the issue of keeping the user configurations after reboot. The idea is to maintain a delay indicator that OA will check and decide to enable/disable flex counter polling.
sonic-net/sonic-buildimage#8500
sonic-net/sonic-swss-common#523
sonic-net/sonic-swss#1877
#1768
Adding you to the discussion thread about this topic.
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…b.json before reboot (sonic-net#1774)" This reverts commit a72e407.
Update sonic-utilities submodule to latest in 202012 branch: [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled sonic-net/sonic-utilities#1678 [route_check] Filter out VNET routes sonic-net/sonic-utilities#1612 [Show] Update the subcommands of Kdump. sonic-net/sonic-utilities#1682 Add mock support for swsscommon classes sonic-net/sonic-utilities#1780 [acl_loader]: add iptype match to the rules for dataplane acl sonic-net/sonic-utilities@205aff8 [202012][fast-reboot] Remove FLEX_COUNTER_TABLE from config_db.json before fast-reboot sonic-net/sonic-utilities#1774
Fix sonic-net/sonic-buildimage#8523
What I did
Remove
FLEX_COUNTER_TABLEfrom config_db.json before fast-reboot to allow delaying FLEX counter polling after fast-reboot.Delaying FLEX counter polling is important to keep fastboot dataplane downtime under 30s.
How I did it
In the going down path, add a step to modify config_db.json - remove the key:value for
FLEX_COUNTER_TABLEtable.How to verify it
Repro'd the issue in the latest 202012 image.
With the fix, the counter polling is delayed and downtime is back to normal.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)