Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minigraph][port_config] Use imported config.main and add conditional patch #1724

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

Blueve
Copy link
Contributor

@Blueve Blueve commented Jul 26, 2021

What I did

We found an issue where UT couldn't pass in old release branch with patch #1705

How I did it

To solve this issue, I applied two change in this PR:

  • Use imported config.main module since we are not import config.main as config in old release branches
  • Add conditional patch since some file were not mocked in old release branches

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants