[Portstat]: Add -p option to support portstat timer #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 15, 2017 23:31
Signed-off-by: Sihui Han <sihan@microsoft.com>
Signed-off-by: Sihui Han <sihan@microsoft.com>
Signed-off-by: Sihui Han <sihan@microsoft.com>
jleveque
suggested changes
Mar 16, 2017
scripts/portstat
Outdated
| """) | ||
| parser.add_argument('-c', '--clear', action='store_true', help='Copy & clear stats') | ||
| parser.add_argument('-d', '--delete', action='store_true', help='Delete saved stats, either the uid or the specified tag') | ||
| parser.add_argument('-D', '--delete-all', action='store_true', help='Delete all saved stats') | ||
| parser.add_argument('-j', '--json', action='store_true', help='Display in JSON format') | ||
| parser.add_argument('-r', '--raw', action='store_true', help='Raw stats (unmodified output of netstat)') | ||
| parser.add_argument('-t', '--tag', type=str, help='Save stats with name TAG', default=None) | ||
| parser.add_argument('-p', '--period', type=int, help='Get the portstat within Period seconds', default=0) |
There was a problem hiding this comment.
Make the help message clearer. Something like, "Display stats over a specified period (in seconds)."
scripts/portstat
Outdated
| else: | ||
| cnstat_print(cnstat_dict, use_json) | ||
| else: | ||
| #wait for sometime and output the result |
There was a problem hiding this comment.
"# Wait for the specified duration then gather new stats and output the difference"
lguohan
reviewed
Mar 17, 2017
scripts/portstat
Outdated
| @@ -204,6 +205,76 @@ def parse_bcmcmd_ps(bcmcmd_output): | |||
| bcmcmd_lines = bcmcmd_output.split("\n") | |||
|
|
|||
|
|
|||
| def get_cnstat(cnstat_dir): | |||
There was a problem hiding this comment.
it does not look the cnstat_dir is really used in this function, can you remove this argument?
lguohan
reviewed
Mar 17, 2017
scripts/portstat
Outdated
| os.makedirs(cnstat_dir) | ||
| except IOError as e: | ||
| print e.errno, e | ||
| sys.exit(1) |
There was a problem hiding this comment.
here you only create a folder, but you do not use it anyway in the function. what's the purpose here? should we move it to some where else?
Signed-off-by: Sihui Han <sihan@microsoft.com>
|
can you make sure the existing portstat -c, portstat works |
lguohan
approved these changes
Mar 18, 2017
jleveque
approved these changes
Mar 20, 2017
|
@sihuihan88: I merged this PR. Please update the sonic-utilities submodule pointer in sonic-buildimage to reference this. |
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
Otherwise ledd ignores signals other than SIGKILL making impossible to use __del__() destructors in LedClass implementations and delays pmon docker container shutdown up to 10s. Signed-off-by: Sergey Popovich <sergey.popovich@ordnance.co>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
This reverts commit 3b1f0ef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.