Create empty ready lists for buffers by default #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
can you explain why test_port_buffer_rel.py pass in the first place? |
|
do not worry about broadcom and mellanox build failure, it is because sai package header mismatch for now. |
|
Because we have buffers in vs https://github.com/Azure/sonic-buildimage/blob/master/platform/vs/docker-sonic-vs/buffers.json.j2 |
lguohan
pushed a commit
that referenced
this pull request
Jul 12, 2018
* Pospone QueueMap initialization until activation of counters * Generate queue maps only for front panel ports * Create empty buffer lists by default
qiluo-msft
reviewed
Aug 23, 2018
| @@ -58,9 +58,20 @@ void BufferOrch::initBufferReadyList(Table& table) | |||
| { | |||
| SWSS_LOG_ENTER(); | |||
|
|
|||
| // init all ports with an empty list | |||
| for (const auto& it: gPortsOrch->getAllPorts()) | |||
There was a problem hiding this comment.
I think gPortsOrch->getAllPorts() will return only one port, the CPU port. Is it what you expected?
qiluo-msft
reviewed
Aug 23, 2018
| @@ -58,9 +58,20 @@ void BufferOrch::initBufferReadyList(Table& table) | |||
| { | |||
| SWSS_LOG_ENTER(); | |||
There was a problem hiding this comment.
This function will be called twice, so m_port_ready_list_ref will be overwritten again. Is it a bug?
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Harish Venkatraman <harish_venkatraman@dell.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add additional logic to initialize ready list as empty by default.
Why I did it
Otherwise the port would be stopped if it doesn't have any buffer configuration
How I verified it
Build an image and run on your DUT
Details if related