Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make reset crm polling interval effective immediately #451

Merged
merged 3 commits into from
Mar 14, 2018
Merged

make reset crm polling interval effective immediately #451

merged 3 commits into from
Mar 14, 2018

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Mar 13, 2018 •
edited
Loading

What I did
make reset crm polling interval effective immediately

Why I did it
it takes too long to run the crm test

How I verified it
passing swss integration test

Details if related

lgh@gulv-vm1:/data/sonic/sonic-swss/tests$ sudo pytest -v --dvsname=vs test_crm.py 
======================================================== test session starts ========================================================
platform linux2 -- Python 2.7.12, pytest-3.3.1, py-1.5.2, pluggy-0.6.0 -- /usr/bin/python
cachedir: .cache
rootdir: /data/sonic/sonic-swss/tests, inifile:
collected 10 items                                                                                                                  

test_crm.py::test_CrmFdbEntry PASSED                                                                                          [ 10%]
test_crm.py::test_CrmIpv4Route PASSED                                                                                         [ 20%]
test_crm.py::test_CrmIpv6Route PASSED                                                                                         [ 30%]
test_crm.py::test_CrmIpv4Nexthop PASSED                                                                                       [ 40%]
test_crm.py::test_CrmIpv6Nexthop PASSED                                                                                       [ 50%]
test_crm.py::test_CrmIpv4Neighbor PASSED                                                                                      [ 60%]
test_crm.py::test_CrmIpv6Neighbor PASSED                                                                                      [ 70%]
test_crm.py::test_CrmNexthopGroup PASSED                                                                                      [ 80%]
test_crm.py::test_CrmNexthopGroupMember PASSED                                                                                [ 90%]
test_crm.py::test_CrmAcl PASSED                                                                                               [100%]

==================================================== 10 passed in 92.19 seconds =====================================================

@lguohan lguohan requested review from qiluo-msft and prsunny March 13, 2018 06:31
prsunny
prsunny approved these changes Mar 13, 2018
View reviewed changes
Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

qiluo-msft
qiluo-msft reviewed Mar 13, 2018
View reviewed changes
orchagent/crmorch.cpp Outdated
@@ -236,6 +236,10 @@ void CrmOrch::handleSetCommand(const string& key, const vector<FieldValueTuple>&
if (field == CRM_POLLING_INTERVAL)
{
m_pollingInterval = chrono::seconds(to_uint<uint32_t>(value));
auto timer = static_cast<ExecutableTimer *>(Orch::getExecutor("CRM_COUNTERS_POLL"))->getSelectableTimer();
Copy link
Contributor

@qiluo-msft qiluo-msft Mar 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timer [](start = 21, length = 5)

It is easier to get the time from ctor (executor). #Closed

qiluo-msft
qiluo-msft reviewed Mar 13, 2018
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comment

@lguohan lguohan merged commit 4dab0c3 into sonic-net:master Mar 14, 2018
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@wendani @lguohan
Add buffer pool stat to flex counter architecture (sonic-net#451)
dcab09f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@prsunny prsunny prsunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lguohan @qiluo-msft @prsunny