[portsyncd] allow port syncd to parse port_config.ini in random column order #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n order - Parse the column header to decide column ordering. - Extra column(s) will be ignored. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
lguohan
approved these changes
Feb 24, 2018
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…el or portchannel members only when it is configured (sonic-net#277) (sonic-net#445)
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…ortchannel or portchannel members only when it is configured (sonic-net#277) (sonic-net#445)" (sonic-net#452) This reverts commit dc5d5c4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I verified it
When processing a port_config.ini with columns name, lanes, alias, index, speed. Though portsyncd ignores the index column, it didn't skip the values in the column, the values were read as speed. Later causing orchagent to crash after setting values in index column as port speed.
With the change, orchagent stayed up, the values were process correctly, and all ports went online.