[pfcwdorch]: Add alert mode #342
Conversation
Alert mode tells watchdog that whenever it detects PFC storm, it should only write message to the log. It is implemented as a separate action along with drop and forward. Signed-off-by: marian-pritsak <marianp@mellanox.com>
| @@ -97,6 +97,7 @@ PfcWdAction PfcWdOrch<DropHandler, ForwardHandler>::deserializeAction(const stri | |||
| { | |||
| { "forward", PfcWdAction::PFC_WD_ACTION_FORWARD }, | |||
| { "drop", PfcWdAction::PFC_WD_ACTION_DROP }, | |||
| { "alert", PfcWdAction::PFC_WD_ACTION_ALERT }, | |||
There was a problem hiding this comment.
is it better to move this const into the header file?
There was a problem hiding this comment.
It is not intended to be used by anyone else. Enum is in header.
There was a problem hiding this comment.
then a const static is better? do you know if the compiler will optimize here to only initialize the variable once?
There was a problem hiding this comment.
const static will be better here. Move out of this function, and make it a cpp global is even better.
There are several cost here:
- time cost: each function call will call the instructor once
- space cost: each template instantiate will create a local map instance
There was a problem hiding this comment.
@qiluo-msft thanks for the explanation.
|
In this pr, in alert mode, it will run restore plugins for stormed queues, which is not correct. Instead, we need to use detect plugin to check stormed queues in alert mode. #343 includes the enhancement. |
* require root privilege for all pfcwd configuration commands (sonic-net#330) Signed-off-by: Guohan Lu <gulv@microsoft.com> * pfcwd start: 1) default restoration time to 2 times detection time if not defined; 2) check if options are prefixed with "--"; Signed-off-by: Wenda <wenni@microsoft.com> * Check if ports list has invalid string element; Correct typo restoration-time Signed-off-by: Wenda <wenni@microsoft.com>
* Change get_tx_bias return type to list Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Alert mode tells watchdog that whenever it detects PFC storm, it should
only write message to the log. It is implemented as a separate action
along with drop and forward.
Signed-off-by: marian-pritsak marianp@mellanox.com