[muxorch] Fixing updateRoute logic #2952
Conversation
What I did: - Removed logic that prevented routes from updating if an active nexthop was already found in updateRoute cache. - added test to check for scenario where ecmp route update triggers after updateRoute programs route to point to single nh - Added logs to some key paths in updateRoute logic to add visibility Why I did it: Bug in logic was causing routes getting updated multiple times to skip updateRoute logic How I did it: removing logic that checked cache for active nexthop Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
| @@ -584,14 +584,14 @@ def multi_nexthop_test(self, dvs, dvs_route, asicdb, appdb, route, neighbors, ma | |||
| print("setting %s to %s" % (mux_ports[toggle_index], ACTIVE)) | |||
| self.set_mux_state(appdb, mux_ports[toggle_index], ACTIVE) | |||
| if start[keep_index] == ACTIVE: | |||
| self.check_route_nexthop(dvs_route, asicdb, route, neighbors[keep_index]) | |||
| self.check_route_nexthop(dvs_route, asicdb, route, neighbors[0]) | |||
There was a problem hiding this comment.
Why is existing test changed?
There was a problem hiding this comment.
The logic changed, so this test was failing. Each time we update the route, we'll be programming the route to point to the first active neighbor. Before this, we were keeping whatever nexthop was previously programmed.
|
@Ndancejic , can you rebase with the latest 202205 and update the test? |
Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
|
Hi @Ndancejic could you update ADO and test result for 202305? |
@StormLiangMS , updated ADO. It is tested and validated on 202205. |
hi @prsunny typo? 202305 or 202205? |
|
@Ndancejic @prsunny suppose typo, just merged. |
* [muxorch] Fixing updateRoute logic What I did: - Removed logic that prevented routes from updating if an active nexthop was already found in updateRoute cache. - added test to check for scenario where ecmp route update triggers after updateRoute programs route to point to single nh - Added logs to some key paths in updateRoute logic to add visibility Why I did it: Bug in logic was causing routes getting updated multiple times to skip updateRoute logic
|
hi @yxieca for 202311 cherry pick. |
What I did:
Microsoft ADO - 25662690
Why I did it:
Bug in logic was causing routes getting updated multiple times to skip updateRoute logic
How I did it:
removing logic that checked cache for active nexthops