[portsorch]: Implement port PFC asym capability check #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18f278e to
504dc7d
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Yakiv-Huryk
approved these changes
Oct 30, 2023
|
@prsunny / @qiluo-msft please help to review & merge |
504dc7d to
294d87f
Compare
|
@prsunny / @qiluo-msft just a kind reminder |
|
@prsunny / @qiluo-msft just a kind reminder |
prsunny
reviewed
Nov 9, 2023
dgsudharsan
previously approved these changes
Nov 9, 2023
volodymyrsamotiy
approved these changes
Nov 10, 2023
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
b2a967c to
1c8510e
Compare
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
prsunny
approved these changes
Nov 10, 2023
|
@StormLiangMS Tested on top of 202305 commit sonic-net/sonic-buildimage@40d1159 |
|
hi @dgsudharsan this is an enhancement, let's have it in next release. |
|
@StormLiangMS This is not enhancement but a bug fix. If a platform doesn’t support pfc asym, by default SONiC will crash. We added a capability to check if pfc asym is supported before programming the configuration to SAI |
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 19, 2023
* [portsorch]: Implement port PFC asym capability check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
Capability check helps to avoid port misconfiguration on systems where PFC asymmetric is not supported
What I did
Why I did it
How I verified it
Details if related