[ACL] Fix acl match ip_type_non_ipv4 and ip_type_non_ipv6. #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LTeng <liuteng@asterfusion.com>
bingwang-ms
approved these changes
Oct 15, 2023
prsunny
approved these changes
Oct 24, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 2, 2023
*Fix acl match ip_type_non_ipv4 and ip_type_non_ipv6.
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Jan 25, 2024
*Fix acl match ip_type_non_ipv4 and ip_type_non_ipv6.
|
Cherry-pick PR to 202205: #3026 |
1 similar comment
Hi @mssonicbld . I'm not sure how it happened. I found the same error in other PR (eg. last commit (https://github.com/sonic-net/sonic-swss/runs/20684050068) in #3006). It looks like a known issue according to the comments of that PR. |
4 similar comments
mssonicbld
pushed a commit
that referenced
this pull request
Mar 4, 2024
*Fix acl match ip_type_non_ipv4 and ip_type_non_ipv6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix acl match ip_type_non_ipv4 and ip_type_non_ipv6.
Signed-off-by: LTeng liuteng@asterfusion.com
What I did
Change the value of IP_TYPE_NON_IPv4 and IP_TYPE_NON_IPv6 to uppercase
Why I did it
As attr_value is converted to uppercase by "to_upper()" in AclRule::processIpType, processIpType will return false when processing non_ipv4 and non_ipv6.
How I verified it
Added pytest.
Details if related