[202205][sai_failure_dump]Invoking dump during SAI failure #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [sai_failure_dump]Invoking dump during SAI failure
prsunny
approved these changes
Feb 9, 2023
|
@yxieca for viz as this is a new addition to orchagent behavior for 202205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2644
What I did
Added logic to invoke SAI failure dump during any SAI programming failure before invoking abort.
Why I did it
To collect necessary dumps in problem state in syncd before abort is called and all processes restarts
How I verified it
Manual verification. Added UT to cover abort scenario as well.
Details if related