[201911] [Flex counters] Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a link to master PR? |
|
@neethajohn following your ask enclose in the backport PR. Appreciate if you can prioritized the review. |
|
/AzurePipelines run LGTM |
|
No pipelines are associated with this pull request. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
neethajohn
reviewed
May 16, 2022
…ew FlexCounter group Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
67b3df4 to
179a7c8
Compare
neethajohn
approved these changes
May 18, 2022
|
@ayurkiv-nvda could you please followup on the LGTM issue raised in this PR? if this infra issue please contact the build team. |
|
@ayurkiv-nvda kindly reminder to check the LGTM |
@liat-grozovik It looks like these LGTM issue for 201911 is know problem |
|
@liat-grozovik |
neethajohn
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jun 22, 2022
…rpoll, show/clear counters) (#2155) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> Should be merged after sonic-net/sonic-swss#2263 Appropriate PR in master:#1355, #1461, #1583 What I did Added new option for "counterpoll" utility Added new CLI commands to view and clear PG dropped packet statistics. Added the new CLI commands to the command reference guide. How I did it Need to merge PG drop functionality to 201911 How to verify it admin@arc-switch1041:~$ counterpoll pg-drop enable --> to enable the new counter admin@arc-switch1041:~$ counterpoll show --> check new INGRESS_PG_STAT_DROP counter status Check counters admin@arc-switch1041:~$ redis-cli -n 2 127.0.0.1:6379[2]> HGETALL COUNTERS:oid:0x1a000000000062 1) "SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES" 2) "0" 3) "SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES" 4) "0" 5) "SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS" 6) "0" show priority-group drop counters Ingress PG dropped packets: Port PG0 PG1 PG2 PG3 PG4 PG5 PG6 PG7 --------- ----- ----- ----- ----- ----- ----- ----- ----- Ethernet0 800 801 802 803 804 805 806 807 Ethernet4 400 401 402 403 404 405 406 407 Ethernet8 100 101 102 103 104 105 106 107 ... sonic-clear priority-group drop counters Cleared PG drop counters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appropriate PR in master #1600
What I did
Added possibility to calculate Priority Group drop packet counters
Why I did it
Need to merge feature from master to 201911
How I verified it
Make sure all entries for forwarding have been correctly established, ARP, routing, neighbor, …
Let’s say it’s Ethernet8, using the following command:
and then save config and reload config.
Send packets from host A to host B, make sure the DSCP is 3.
You should be able to observe discard on PG 3 soon.
Details if related