[nbrmgrd] added function to parse IP address from APP_DB #1672
Conversation
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
| time.sleep(2) | ||
|
|
||
| (exitcode, output) = dvs.runcmd(['sh', '-c', "supervisorctl status nbrmgrd | awk '{print $2}'"]) | ||
| assert output == "RUNNING\n" |
There was a problem hiding this comment.
Is it ok if you can also check whether the req has been sent out? Like parsing ip neigh show for 2000:1::1. This way we can verify the functionality. It might be in 'failed' state which is ok.
There was a problem hiding this comment.
The ip neigh show command produced the empty output, it seems like because in test_FlushResolveNeighborIpv6 we don't test the whole flow of flushing the neighbor entry, because it is impossible to do on the VS.
When we did testing on the VS we actually saw a crash from the issues/7045 and with this fix the crash wasn't observed.
So, in any case, I believe this verification should be enough to cover the changes, even if we are not able to check ip neigh show.
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 1672 in repo Azure/sonic-swss |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* [nbrmgrd] added function to parse IP address from APP_DB Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
…onic-net#1672) What I did Pcieutil to load the platform api first instead of using common api Some platform device with different BIOS version needs more than one pcie configuration to check the pcie devices properly. Please refer to the platform api support : sonic-net/sonic-platform-common#195 How I did it Load the platform pcie api first prior to use the common api
Signed-off-by: Vadym Hlushko vadymh@nvidia.com
What I did
Added specific function to parse keys from
APP_DBwhich looks like:"NEIGH_RESOLVE_TABLE:Vlan2:2000:1::1""NEIGH_RESOLVE_TABLE:Vlan2:192.168.0.10"Why I did it
The fix for the issues/7045.
How I verified it
Provided the VS tests.
Also, it was verified manually, error messages and crash from the issues/7045 wasn't observed.