Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911][acl] Handle uncaught exception in aclorch #1667

Open
wants to merge 2 commits into
base: 201911
Choose a base branch
from
Open

[201911][acl] Handle uncaught exception in aclorch #1667

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca48b9f
[201911][acl] Handle uncaught exception in aclorch
daall Mar 9, 2021
904b1c0
Make exception type more specific
daall Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions orchagent/aclorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2903,8 +2903,16 @@ void AclOrch::doAclRuleTask(Consumer &consumer)
type = table_id == m_mirrorTableId[stage] ? ACL_TABLE_MIRROR : ACL_TABLE_MIRRORV6;
}


newRule = AclRule::makeShared(type, this, m_mirrorOrch, m_dTelOrch, rule_id, table_id, t);
try
{
newRule = AclRule::makeShared(type, this, m_mirrorOrch, m_dTelOrch, rule_id, table_id, t);
}
catch (exception &e)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exception [](start = 19, length = 9)

exception type is too generic and possibly hide code bug. Could you list all possible excpetion types?
This comment is also applicable to master branch. So if you found better solution, let's start a PR on master first.

{
SWSS_LOG_ERROR("Error while creating ACL rule %s: %s", rule_id.c_str(), e.what());
it = consumer.m_toSync.erase(it);
return;
}

for (const auto& itr : kfvFieldsValues(t))
{
Expand Down