New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated PFCWD to use single ACL table for PFCWD and MUX #1620

Merged

vmittal-msft merged 6 commits into sonic-net:master from vmittal-msft:pfcwd_acl_changes

Feb 23, 2021

Contributor

vmittal-msft commented Feb 1, 2021 •

edited

Loading

What I did
Allow PFCWD and MUX features to use single ACL table on ingress side.
Why I did it
It is done to save space and to allow new features to make use of ACL table.
How I verified it
Verified by running tests on TD3 platform.
Details if related

vmittal-msft force-pushed the pfcwd_acl_changes branch from 6874b93 to 7e5775d Compare

February 1, 2021 20:13

vmittal-msft requested a review from daall

February 1, 2021 20:18

lgtm-com bot commented Feb 1, 2021

This pull request introduces 1 alert when merging 7e5775d into 288fb40 - view on LGTM.com

new alerts:

1 for Declaration hides parameter

lguohan reviewed

View reviewed changes

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

vmittal-msft force-pushed the pfcwd_acl_changes branch from 7e5775d to b79c541 Compare

February 4, 2021 00:48

vmittal-msft requested review from neethajohn and prsunny

February 4, 2021 01:00

vmittal-msft marked this pull request as ready for review

February 4, 2021 01:00

prsunny reviewed

View reviewed changes

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/aclorch.h Outdated Show resolved Hide resolved

orchagent/aclorch.cpp Show resolved Hide resolved

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

daall suggested changes

View reviewed changes

Contributor

daall left a comment

as comments

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/aclorch.cpp Show resolved Hide resolved

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved

vmittal-msft added 2 commits

February 8, 2021 18:11


          Updated PFCWD to use single ACL table for PFCWD and MUX

379a018


           Changes to make update ACL rule API usable for generic purpose

63a34ac

vmittal-msft force-pushed the pfcwd_acl_changes branch from b7cf8be to 63a34ac Compare

February 8, 2021 18:14

prsunny reviewed

View reviewed changes

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

daall reviewed

View reviewed changes

orchagent/pfcactionhandler.cpp Show resolved Hide resolved

neethajohn reviewed

View reviewed changes

Contributor

neethajohn left a comment

Haven't reviewed the vs test. will look at it when it is complete

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

tests/mock_tests/aclorch_ut.cpp Outdated Show resolved Hide resolved

orchagent/aclorch.cpp Show resolved Hide resolved

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved


          Changes to add code review comments

62bba89

neethajohn reviewed

View reviewed changes

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

neethajohn reviewed

View reviewed changes

tests/test_pfcwd.py Outdated Show resolved Hide resolved


          Added VS test for PFCWD changes

67566ea

daall reviewed

View reviewed changes

orchagent/aclorch.cpp Show resolved Hide resolved

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/pfcactionhandler.cpp Outdated Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved

tests/test_pfcwd.py Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved

tests/test_pfcwd.py Outdated Show resolved Hide resolved


          Added feedback to VS test and other functions

6bdebee

vmittal-msft force-pushed the pfcwd_acl_changes branch from 4e9db08 to 6bdebee Compare

February 19, 2021 22:22

daall previously approved these changes

View reviewed changes

prsunny reviewed

View reviewed changes

orchagent/aclorch.h Outdated Show resolved Hide resolved

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

orchagent/aclorch.cpp Outdated Show resolved Hide resolved

vmittal-msft dismissed daall’s stale review via

1298caa

February 21, 2021 23:50


          Completed final set of review comments

3f41af9

vmittal-msft force-pushed the pfcwd_acl_changes branch from 1298caa to 3f41af9 Compare

February 22, 2021 18:16

Contributor Author

vmittal-msft commented Feb 22, 2021

retest vs please

prsunny approved these changes

View reviewed changes

Collaborator

prsunny left a comment

lgtm.

vmittal-msft merged commit 97b3913 into sonic-net:master

vmittal-msft deleted the pfcwd_acl_changes branch

February 23, 2021 00:16

vmittal-msft added the Request for 202012 Branch label

yxieca added the Included in 202012 Branch label

yxieca pushed a commit that referenced this pull request


          Updated PFCWD to use single ACL table for PFCWD and MUX (#1620)

6c285f6

Updated PFCWD to use single ACL table for PFCWD and MUX

DavidZagury pushed a commit to DavidZagury/sonic-swss that referenced this pull request


          Updated PFCWD to use single ACL table for PFCWD and MUX (sonic-net#1620)

30103e3

Updated PFCWD to use single ACL table for PFCWD and MUX

raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request


          Updated PFCWD to use single ACL table for PFCWD and MUX (sonic-net#1620)

d357d5f

Updated PFCWD to use single ACL table for PFCWD and MUX

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request


          Replace swsssdk.ConfigDBConnector and SonicDBConfig with swsscommon i…

cd69473

…mplementation (sonic-net#1620)

swsssdk will be deprecated. Use swsscommon instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Included in 202012 Branch Request for 202012 Branch