[dvs] Add new common issues and TOC to DVS README #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Allen <daall@microsoft.com>
lguohan
approved these changes
Aug 21, 2020
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Clean up sfpshow utility - Reword header docstring and comments - Unify formatting - Rename variables and constants - Use `+=` for string concatenation to reduce line length - Pass through `autopep8 --max-line-length 120`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
What I did
I added some notes to the README and a table of contents.
Why I did it
I added the notes in response to recent feedback and questions I got from different community members who had tried out the new instructions.
I also added the table of contents as it is useful to be able to be able to jump around (especially if you already have the DVS set up and you just want to read about the options).
How I verified it
N/A
Details if related
N/A