Move away sairedis logrotate from signal handler #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
qiluo-msft
reviewed
Dec 18, 2019
| @@ -47,6 +47,7 @@ int gBatchSize = DEFAULT_BATCH_SIZE; | |||
| bool gSairedisRecord = true; | |||
| bool gSwssRecord = true; | |||
| bool gLogRotate = false; | |||
| bool gSaiRedisLogRotate = false; | |||
qiluo-msft
reviewed
Dec 18, 2019
| @@ -47,6 +47,7 @@ int gBatchSize = DEFAULT_BATCH_SIZE; | |||
| bool gSairedisRecord = true; | |||
| bool gSwssRecord = true; | |||
| bool gLogRotate = false; | |||
There was a problem hiding this comment.
gLogRotate [](start = 5, length = 10)
The name seems cover gSaiRedisLogRotate. Do you mean gOrchagentLogRotate ?
There was a problem hiding this comment.
no, this logrotate only covers sairedis library
|
not sure why tests fails on VS, seems not related to my change |
|
retest this please |
|
test this please |
qiluo-msft
approved these changes
Dec 22, 2019
abdosi
pushed a commit
that referenced
this pull request
Feb 4, 2020
* Move away sairedis logrotate from signal handler * Update tests
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
*[Cisco] enable SAI bulk API config from syncd to pass a set of Rid and review code-flow performance on cisco SAI/SDK layer. until route-check.py(sonic-utility) will not dump the associated ERR message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Move away logrotate from signal handler to main orch loop, to not execute any sairedis library code which potentially can be under mutex and cause deadlock when signal handler occur
Why I did it
to not execute sai_switch_api->set_attribute() under signal handler, just to set logrotate flag
How I verified it
running orchagent against vs switch and sending HUP signal to orch process
Details if related
Since flush method is executed every time that select is returning object from orchdaemon main/start loop, this is good point to check if logrotate is needed