Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntfsOrch subnet overlap checking and retry should be changed #659

Open
jipanyang opened this issue Oct 30, 2018 · 1 comment
Open

IntfsOrch subnet overlap checking and retry should be changed #659

jipanyang opened this issue Oct 30, 2018 · 1 comment
Labels
Question ❓

Comments

@jipanyang
Copy link
Contributor

For interface ip config, intforch perform subnet overlap checking and keep retrying if overlap exists on an interface, this is to handling ifconfig specific behavior.

With the change of ip config from linux interface file to intfmgrd, ifconfig is not used any more.
Also if user configured two overlapping subnet on an interface, it causes log storming. Probably that should be prevented at portmgrd(?)

* NOTE: Overlap checking is required to handle ifconfig weird behavior.
             * When set IP address using ifconfig command it applies it in two stages.
             * On stage one it sets IP address with netmask /8. On stage two it
             * changes netmask to specified in command. As DB is async event to
             * add IP address with original netmask may come before event to
             * delete IP with netmask /8. To handle this we in case of overlap
             * we should wait until entry with /8 netmask will be removed.
             * Time frame between those event is quite small.*/

https://github.com/Azure/sonic-swss/blob/65b015b17a42013c988b871654f9b4edfb75e749/orchagent/intfsorch.cpp#L172
@stcheng
Copy link
Contributor

stcheng commented Nov 1, 2018

agree all the extra logic dealing with ifconfig shall be removed

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this issue Feb 28, 2022
@PrabhuSreenivasan @renukamanavalan
SONiC Management Framework Release 1.0 (sonic-net#659)
e0e8c2f 
* Added scripts to provide back-end for CLI commands

Scripts to provide the files /var/platform/syseeprom and /var/paltform/system,
which are JSON files read by CLI commands, to provide system information.

Signed-off-by: Howard Persh <Howard_Persh@dell.com>

* Change system information poll to not use file locking

Signed-off-by: Howard Persh <Howard_Persh@dell.com>

* Modify system system info poller to provide process start time in seconds

Signed-off-by: Howard Persh <Howard_Persh@dell.com>

* Small optimization for system info poll script

Signed-off-by: Howard Persh <Howard_Persh@dell.com>

* Add new scripts for CLI backend to setup.py

Signed-off-by: Howard Persh <Howard_Persh@dell.com>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this issue Feb 28, 2022
@renukamanavalan
Revert "SONiC Management Framework Release 1.0 (sonic-net#659)" (soni…
0ada5cf 
…c-net#741)

This reverts commit e0e8c2f.
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this issue Mar 1, 2023
@kcudnik
Add ZeroMQ communication channel between sairedis and syncd (sonic-ne…
1d84b90 
…t#659)

* [sairedis] Use separate db connector for VID index generator

* [sairedis] Add Channel class

* [sairedis] Start using Channel class in RedisChannel

* [sairedis] Add zmq configuration to ContextConfig

* [sairedis] Change reddis channel class to base channel class

* [syncd] Fix aspell

* [sairedis] Disable zeromq by default

* [sairedis] Add ZeroMQChannel class

* Update aspell

* [syncd] Add NotificationProducerBase class

* [syncd] Add RedisNotificationProducer class

* [syncd] Start using RediisNotificationProducer class

* [syncd] Add ZeroMQNotificationProducer class

* [syncd] Start uisng ZeroMQNotificationProducer class

* [sairedis] Start using ZeroMQChannel clas

* [saiplayer] Use lib zmq in saiplayer Makefile

* [tests] Add libzmq to makefile

* [sairedis] Force sync mode when zmq enabled

* [syncd] Force sync mode when zmq enabled

* [syncd] Add libzmq to makefile

* [syncd] Add SelectableChannel class

* [syncd] Add RedisSelectableChannel class

* [syncd] Start using SelectableChannel base

* [saidump] Add libzmq to makefile

* [syncd] Add ZeroMQSelectableChannel class

* [syncd] Start using ZeroMQSelectableChannel

* [sairedis] Remove unused includes from Channel class

* [sairedis] Fix ZeroMQChannel error checks

* [syncd] Use zmq_poll in separate thread to ignore edge trigger poll

* [sairedis] Fix aspell

* [tests] Update aspell dict

* [tests] Add zmq channel unittests

* [syncd] Fix ZeroMQNotificationProducer connect error code

* Update aspell

* [syncd] Increase ZeroMQSelectableChannel timeout to 2min

* Update aspell

* Modify libzmq order in Makefiles

* [syncd] Fix merge issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Question ❓
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stcheng @jipanyang