ASIC internal temperature sensors support #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Nov 24, 2020
jleveque
previously approved these changes
Nov 25, 2020
qiluo-msft
reviewed
Nov 25, 2020
qiluo-msft
approved these changes
Nov 25, 2020
jleveque
approved these changes
Nov 25, 2020
|
Submodule update PR: sonic-net/sonic-buildimage#6042 |
prsunny
reviewed
Dec 2, 2020
| @@ -74,6 +74,9 @@ namespace swss { | |||
| #define APP_STP_FASTAGEING_FLUSH_TABLE_NAME "STP_FASTAGEING_FLUSH_TABLE" | |||
| #define APP_STP_BPDU_GUARD_TABLE_NAME "STP_BPDU_GUARD_TABLE" | |||
|
|
|||
| /***** ASIC DATABASE *****/ | |||
| #define ASIC_TEMPERATURE_INFO_TABLE_NAME "ASIC_TEMPERATURE_INFO" | |||
There was a problem hiding this comment.
Sorry for the late comment - This should not belong here as the section is for APP DB entries. From the usage, it looks to be part of STATE DB entries.
Is it possible to correct this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASIC internal temperature sensors support
More details:
sonic-net/sonic-swss#1517
Details if related
HLD Location: https://github.com/Azure/SONiC/blob/master/doc/asic_thermal_monitoring_hld.md