[syncd] Fix bulk api object type for next hop group members #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Oct 30, 2020
|
retest this please |
|
retest vs please |
|
retest this please |
1 similar comment
|
retest this please |
|
retest vs please |
1 similar comment
|
retest vs please |
|
retest this please |
1 similar comment
|
retest this please |
|
i think there are still some problem on the bulk api, can you temporarily enable -l option and check if vstest passing? |
|
for this PR ? or other PR ? |
|
for example, the previous pr checker results. https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-sairedis-build-pr/656/ |
|
well, let me do this. let's merge this pr and open a new pr to do the test. |
dmytroxshevchuk
added a commit
to dmytroxshevchuk/sonic-sairedis
that referenced
this pull request
Nov 5, 2020
…onic-net#685)" This reverts commit 797197c.
dmytroxshevchuk
added a commit
to dmytroxshevchuk/sonic-sairedis
that referenced
this pull request
Mar 4, 2021
…onic-net#685)" This reverts commit 797197c.
KostiantynYarovyiBf
added a commit
to KostiantynYarovyiBf/sonic-sairedis
that referenced
this pull request
Sep 21, 2021
…onic-net#685)" This reverts commit 797197c.
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
…t#685) SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER object type should be used for m_apis.next_hop_group_api->create_next_hop_group_members NEXT_HOP_GROUP object type has no bulk api at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER object type should be used for m_apis.next_hop_group_api->create_next_hop_group_members
NEXT_HOP_GROUP object type has no bulk api at all