Remove lane map divide restriction #290
Conversation
syncd/syncd_saiswitch.cpp
Outdated
| */ | ||
|
|
||
| if (laneMap.size() < 32 || (laneMap.size() % 16 != 0)) | ||
| if (laneMap.size() < 32) |
There was a problem hiding this comment.
it is interesting to have this check? any reason? if the switch has less than 32 ports, then we print error?
There was a problem hiding this comment.
I mean why do check the lanemap size at all? there could be switch with less than 32 ports.
There was a problem hiding this comment.
i added this at first to rule out some errors and mistakes with configuration file since we didnt used any other configuration, but can there be a switch with sonic with 5 ports? :P
|
this is still not merged? |
|
I think all of the checks should be removed. |
|
You can merge this any time, and those checks were put there initially to prevent bugs on SAI from vendos, and at the beginning we only dealed with 1 type of switch so there was no issue, also i think right now we will not have less than 32 ports in switch and i would leave this as a safety check and remove when switch will less than 32 ports come to play |
|
ok. can you check the ERROR to NOTICE? |
|
I removed this restriction at all |
* Remove lane map divide restriction * Remove lane size restriction
No description provided.