Namespace support for the python classes. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Mar 13, 2020
qiluo-msft
reviewed
Mar 13, 2020
qiluo-msft
reviewed
Mar 13, 2020
qiluo-msft
reviewed
Mar 17, 2020
qiluo-msft
reviewed
Mar 18, 2020
qiluo-msft
reviewed
Mar 18, 2020
qiluo-msft
reviewed
Mar 18, 2020
qiluo-msft
reviewed
Mar 18, 2020
qiluo-msft
reviewed
Mar 20, 2020
qiluo-msft
reviewed
Mar 20, 2020
qiluo-msft
reviewed
Mar 20, 2020
qiluo-msft
reviewed
Mar 20, 2020
qiluo-msft
reviewed
Mar 20, 2020
qiluo-msft
reviewed
Mar 20, 2020
qiluo-msft
reviewed
Mar 20, 2020
qiluo-msft
reviewed
Mar 20, 2020
qiluo-msft
reviewed
Mar 20, 2020
qiluo-msft
reviewed
Mar 20, 2020
judyjoseph
commented
Mar 20, 2020
qiluo-msft
reviewed
Mar 26, 2020
qiluo-msft
reviewed
Mar 26, 2020
qiluo-msft
reviewed
Mar 26, 2020
qiluo-msft
reviewed
Mar 26, 2020
qiluo-msft
reviewed
Mar 26, 2020
Error out if the user don't explicitly call SonicDBConfig.load_sonic_global_db_config in his application. Also add a new parameter "namespace" to SonicDBConfig.load_sonic_global_db_config() it is an optimized version and just loads a single json file for that namespace i.s.o loading all json files present.
|
This pull request introduces 1 alert when merging 56e057f into 154f381 - view on LGTM.com new alerts:
|
qiluo-msft
previously approved these changes
Apr 20, 2020
lguohan
reviewed
Apr 21, 2020
lguohan
reviewed
Apr 21, 2020
lguohan
reviewed
Apr 21, 2020
lguohan
reviewed
Apr 21, 2020
lguohan
reviewed
Apr 21, 2020
lguohan
reviewed
Apr 21, 2020
…comments addressed.
lguohan
reviewed
Apr 22, 2020
lguohan
approved these changes
Apr 23, 2020
|
@judyjoseph , there's conflict cherry-picking. Please raise a separate PR for 201911 branch for this. Thanks. |
This PR has dependencies with the changes done in the commits just before this (eg: d1a1512) , so cannot cherrypick this one alone... Is it possible to advance the sonic-py-swssdk submodule in 201911 ? I can raise a PR for advancing the submodule itself in 201911. |
abdosi
pushed a commit
that referenced
this pull request
May 5, 2020
This PR is the changes needed to support multiple namespaces for the Multi-ASIC devices. Multi-DB namespace PR --> (sonic-net/SONiC#567) The changes are mainly to these classes SonicDBConfig SonicV2Connector/ConfigDBConnector A new parameter "namespace" is added to the SonicV2Connector class init , to pass the namespace name. The default value is None representing empty namespace. class SonicV2Connector(DBInterface): def init(self, use_unix_socket_path=False, namespace=None, **kwargs): If the user don't explicitly set this parameter, namespace takes None as value, and connects to the db_name in the local context, which refers to the database docker running in the current namespace wherever you are running this application/script …. (It could be either Linux host or any specific network namespace ). In this way it is backward compatible and the existing behavior of APIs in these utility classes are maintained. In the SonicDBConfig, a new API is introduced load_sonic_global_db_config() which loads the /var/run/redis/sonic-db/database_global.json file if present. This file has the mapping between the namespace name and the corresponding database_config.json file.
qiluo-msft
reviewed
May 28, 2020
| self.assertEqual(ns_input, ns_list) | ||
|
|
||
| # This is the test to check if the global config file and get the correct DB in a namespace | ||
| def test__namespace_list(self): |
There was a problem hiding this comment.
Duplicated function name
qiluo-msft
reviewed
Aug 7, 2020
| if SonicDBConfig._sonic_db_global_config_init == True: | ||
| return | ||
|
|
||
| if os.path.isfile(global_db_file_path) == True: |
There was a problem hiding this comment.
global_db_file_path [](start = 26, length = 19)
If global_db_file_path does not exist, why set _sonic_db_global_config_init to True?
Also can you return _sonic_db_global_config_init value to caller?
praveen-li
pushed a commit
to praveen-li/sonic-py-swsssdk
that referenced
this pull request
May 4, 2021
This PR is the changes needed to support multiple namespaces for the Multi-ASIC devices. Multi-DB namespace PR --> (sonic-net/SONiC#567) The changes are mainly to these classes SonicDBConfig SonicV2Connector/ConfigDBConnector A new parameter "namespace" is added to the SonicV2Connector class init , to pass the namespace name. The default value is None representing empty namespace. class SonicV2Connector(DBInterface): def init(self, use_unix_socket_path=False, namespace=None, **kwargs): If the user don't explicitly set this parameter, namespace takes None as value, and connects to the db_name in the local context, which refers to the database docker running in the current namespace wherever you are running this application/script …. (It could be either Linux host or any specific network namespace ). In this way it is backward compatible and the existing behavior of APIs in these utility classes are maintained. In the SonicDBConfig, a new API is introduced load_sonic_global_db_config() which loads the /var/run/redis/sonic-db/database_global.json file if present. This file has the mapping between the namespace name and the corresponding database_config.json file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the changes needed to support multiple namespaces for the Multi-ASIC devices. Multi-DB namespace PR --> (sonic-net/SONiC#567)
The changes are mainly to these classes
A new parameter "namespace" is added to the SonicV2Connector class init , to pass the namespace name. The default value of is kept as None which is representing case when user didn't give a namespace name.
class SonicV2Connector(DBInterface):
def init(self, use_unix_socket_path=False, namespace=None, **kwargs):
If the user don't explicitly set this parameter, namespace takes '' as value, and connects to the db_name in the local context. When I mean local context, it refers to the database docker running in the current namespace wherever you are running this application/script …. ( It could be either Linux host or any specific network namespace ). In this way it is backward compatible and the existing behavior of APIs in these utility classes are maintained.
In the SonicDBConfig, a new API is introduced load_sonic_global_db_config() which loads the /var/run/redis/sonic-db/database_global.json file if present. This file has the mapping between the namespace name and the corresponding database_config.json file.
How to verify it
Verified the dockers come up in the Multi-ASIC platform and the config commands too were verified to an extend.
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)