Failed to set Pre-emphasis settings with new xcvr package #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prgeor
reviewed
Nov 8, 2021
prgeor
approved these changes
Nov 8, 2021
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…net#223) * Implement SFF-8472 * Remove duplicate cmis module monitors field * Fix TestDateField * Fix rx power and tx power scale * Add tests * Add FixedNumberRegField, enhance sff8472 tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With new xcvr package, xcvrd fails to set pre-emphasis settings
Motivation and Context
Return types has to be handled properly in xcvrd while handling media settings.
How Has This Been Tested?
Tested in DellEMC Z9332f platform.
cable_len_UT.txt
Additional Information (Optional)