Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occassional test_sfp_insert_events failure #215

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Fix occassional test_sfp_insert_events failure #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sonic-xcvrd/tests/test_xcvrd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,11 +407,12 @@ def test_sfp_insert_events(self):
start = time.time()
while True:
_wrapper_soak_sfp_insert_event(sfp_insert_events, insert)
assert not bool(insert)
if time.time() - start > MGMT_INIT_TIME_DELAY_SECS:
break
assert not bool(insert)
assert insert == port_dict


def test_sfp_remove_events(self):
from xcvrd.xcvrd import _wrapper_soak_sfp_insert_event
sfp_insert_events = {}
Expand All @@ -423,4 +424,4 @@ def test_sfp_remove_events(self):
time.sleep(1)
_wrapper_soak_sfp_insert_event(sfp_insert_events, removal)

assert port_dict == removal
assert port_dict == removal