Initialize unsupported values to 'N/A' in CmisApi::get_transceiver_info #545
+194
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mihirpat1
reviewed
Feb 20, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Feb 21, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ea4a78e to
4fc7a86
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4fc7a86 to
24fa1ce
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@mihirpat1 updated the description accordingly. |
mihirpat1
reviewed
Feb 26, 2025
mihirpat1
reviewed
Feb 26, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Feb 27, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mihirpat1
reviewed
Feb 28, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mihirpat1
reviewed
Feb 28, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mihirpat1
reviewed
Feb 28, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
82b0fd5 to
c6fa955
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mihirpat1
approved these changes
Mar 1, 2025
prgeor
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initialize all the unsupported values of TRANSCEIVER_INFO for CMIS specific interfaces in CmisApi::get_transceiver_info().
Motivation and Context
By initializing values in CmisApi::get_transceiver_info() will simplify the logic in post_port_sfp_info_to_db(). Also, avoids duplication of the code and makes it future ready for any newly added key:value pairs.
How Has This Been Tested?
Additional Information (Optional)
Before the changes:
$ sfputil show eeprom -d -p Ethernet4
Ethernet4: SFP EEPROM detected
Active App Selection Host Lane 1: 1
Active App Selection Host Lane 2: 1
Active App Selection Host Lane 3: 1
Active App Selection Host Lane 4: 1
Active App Selection Host Lane 5: 1
Active App Selection Host Lane 6: 1
Active App Selection Host Lane 7: 1
Active App Selection Host Lane 8: 1
Application Advertisement: 100GAUI-1-L C2M (Annex 120G) - Host Assign (0xff) - 100GBASE-DR (Cl 140) - Media Assign (0xff)
200GAUI-2-L C2M (Annex 120G) - Host Assign (0x55) - Undefined - Media Assign (0x55)
400GAUI-4-L C2M (Annex 120G) - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
IB NDR - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
800G L C2M (placeholder) - Host Assign (0x1) - 800GBASE-DR8 (placeholder) - Media Assign (0x1)
200GAUI-4 C2M (Annex 120E) - Host Assign (0x11) - 200GBASE-DR4 (Cl 121) - Media Assign (0x11)
IB HDR (Arch.Spec.Vol.2) - Host Assign (0x11) - 200GBASE-DR4 (Cl 121) - Media Assign (0x11)
100GAUI-1-S C2M (Annex 120G) - Host Assign (0xff) - 100GBASE-DR (Cl 140) - Media Assign (0xff)
200GAUI-2-S C2M (Annex 120G) - Host Assign (0x55) - Undefined - Media Assign (0x55)
400GAUI-4-S C2M (Annex 120G) - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
800G S C2M (placeholder) - Host Assign (0x1) - 800GBASE-DR8 (placeholder) - Media Assign (0x1)
CMIS Revision: 5.2
Connector: MPO 2x12
Encoding: N/A
Extended Identifier: Power Class 8 (15.0W Max)
Extended RateSelect Compliance: N/A
Hardware Revision: 1.10
Host Electrical Interface: 100GAUI-1-L C2M (Annex 120G)
Host Lane Assignment Options: 255
Host Lane Count: 1
Identifier: OSFP 8X Pluggable Transceiver
Length Cable Assembly(m): 0.0
Media Interface Code: 100GBASE-DR (Cl 140)
Media Interface Technology: 1310 nm DFB
Media Lane Assignment Options: 255
Media Lane Count: 1
Nominal Bit Rate(100Mbs): 0
Specification compliance: sm_media_interface
Vendor Date Code(YYYY-MM-DD Lot): XXXXX
Vendor Name: XXXXXX
Vendor OUI: XXXXXX
Vendor PN: XXXXXX
Vendor Rev: XXXX
Vendor SN: XXXXXX
ChannelMonitorValues:
RX1Power: 3.042dBm
RX2Power: 2.777dBm
RX3Power: 3.309dBm
RX4Power: 3.186dBm
RX5Power: 3.15dBm
RX6Power: 3.184dBm
RX7Power: 2.26dBm
RX8Power: 2.615dBm
TX1Bias: 0.0mA
TX1Power: -40.0dBm
TX2Bias: 0.0mA
TX2Power: -40.0dBm
TX3Bias: 0.0mA
TX3Power: -40.0dBm
TX4Bias: 0.0mA
TX4Power: -40.0dBm
TX5Bias: 129.912mA
TX5Power: 2.097dBm
TX6Bias: 129.912mA
TX6Power: 2.367dBm
TX7Bias: 129.912mA
TX7Power: 1.55dBm
TX8Bias: 129.912mA
TX8Power: 2.067dBm
ChannelThresholdValues:
RxPowerHighAlarm : 4.5dBm
RxPowerHighWarning: 4.0dBm
RxPowerLowAlarm : -6.402dBm
RxPowerLowWarning : -5.901dBm
TxBiasHighAlarm : 340.0mA
TxBiasHighWarning : 320.0mA
TxBiasLowAlarm : 40.0mA
TxBiasLowWarning : 60.0mA
TxPowerHighAlarm : 6.0dBm
TxPowerHighWarning: 5.0dBm
TxPowerLowAlarm : -4.901dBm
TxPowerLowWarning : -3.901dBm
ModuleMonitorValues:
Temperature: 35.766C
Vcc: 3.339Volts
ModuleThresholdValues:
TempHighAlarm : 80.0C
TempHighWarning: 75.0C
TempLowAlarm : -10.0C
TempLowWarning : -5.0C
VccHighAlarm : 3.6Volts
VccHighWarning : 3.465Volts
VccLowAlarm : 3.0Volts
VccLowWarning : 3.135Volts
$ show interfaces transceiver info Ethernet4
Ethernet4: SFP EEPROM detected
Active Firmware: XXXXXX
Active application selected code assigned to host lane 1: N/A
Active application selected code assigned to host lane 2: N/A
Active application selected code assigned to host lane 3: N/A
Active application selected code assigned to host lane 4: N/A
Active application selected code assigned to host lane 5: 1
Active application selected code assigned to host lane 6: N/A
Active application selected code assigned to host lane 7: N/A
Active application selected code assigned to host lane 8: N/A
Application Advertisement: 100GAUI-1-L C2M (Annex 120G) - Host Assign (0xff) - 100GBASE-DR (Cl 140) - Media Assign (0xff)
200GAUI-2-L C2M (Annex 120G) - Host Assign (0x55) - Undefined - Media Assign (0x55)
400GAUI-4-L C2M (Annex 120G) - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
IB NDR - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
800G L C2M (placeholder) - Host Assign (0x1) - 800GBASE-DR8 (placeholder) - Media Assign (0x1)
200GAUI-4 C2M (Annex 120E) - Host Assign (0x11) - 200GBASE-DR4 (Cl 121) - Media Assign (0x11)
IB HDR (Arch.Spec.Vol.2) - Host Assign (0x11) - 200GBASE-DR4 (Cl 121) - Media Assign (0x11)
100GAUI-1-S C2M (Annex 120G) - Host Assign (0xff) - 100GBASE-DR (Cl 140) - Media Assign (0xff)
200GAUI-2-S C2M (Annex 120G) - Host Assign (0x55) - Undefined - Media Assign (0x55)
400GAUI-4-S C2M (Annex 120G) - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
800G S C2M (placeholder) - Host Assign (0x1) - 800GBASE-DR8 (placeholder) - Media Assign (0x1)
CMIS Rev: 5.2
Connector: MPO 2x12
Encoding: N/A
Extended Identifier: Power Class 8 (15.0W Max)
Extended RateSelect Compliance: N/A
Host Lane Count: 1
Identifier: OSFP 8X Pluggable Transceiver
Inactive Firmware: XXXXXX
Length Cable Assembly(m): 0.0
Media Interface Technology: 1310 nm DFB
Media Lane Count: 1
Module Hardware Rev: 1.10
Nominal Bit Rate(100Mbs): 0
Specification compliance: sm_media_interface
Supported Max Laser Frequency: N/A
Supported Max TX Power: N/A
Supported Min Laser Frequency: N/A
Supported Min TX Power: N/A
Vendor Date Code(YYYY-MM-DD Lot): XXXXX
Vendor Name: XXXXXXX
Vendor OUI: XXXXX
Vendor PN: XXXXXX
Vendor Rev: XXXXXX
Vendor SN: XXXXX
After the changes:
$ sfputil show eeprom -d -p Ethernet4
Ethernet4: SFP EEPROM detected
Active App Selection Host Lane 1: 5
Active App Selection Host Lane 2: 5
Active App Selection Host Lane 3: 5
Active App Selection Host Lane 4: 5
Active App Selection Host Lane 5: 5
Active App Selection Host Lane 6: 5
Active App Selection Host Lane 7: 5
Active App Selection Host Lane 8: 5
Application Advertisement: 400GAUI-4-L C2M (Annex 120G) - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
400GAUI-4-S C2M (Annex 120G) - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
100GAUI-1-L C2M (Annex 120G) - Host Assign (0xff) - 100GBASE-DR (Cl 140) - Media Assign (0xff)
100GAUI-1-S C2M (Annex 120G) - Host Assign (0xff) - 100GBASE-DR (Cl 140) - Media Assign (0xff)
200GAUI-2-L C2M (Annex 120G) - Host Assign (0x55) - Undefined - Media Assign (0x55)
200GAUI-2-S C2M (Annex 120G) - Host Assign (0x55) - Undefined - Media Assign (0x55)
800G L C2M (placeholder) - Host Assign (0x1) - 800GBASE-DR8 (placeholder) - Media Assign (0x1)
CMIS Revision: 5.1
Connector: MPO 2x12
Encoding: N/A
Extended Identifier: Power Class 8 (16.0W Max)
Extended RateSelect Compliance: N/A
Hardware Revision: 1.0
Host Electrical Interface: 400GAUI-4-L C2M (Annex 120G)
Host Lane Assignment Options: 17
Host Lane Count: 4
Identifier: OSFP 8X Pluggable Transceiver
Length Cable Assembly(m): 0.0
Media Interface Code: 400GBASE-DR4 (Cl 124)
Media Interface Technology: 1310 nm EML
Media Lane Assignment Options: 17
Media Lane Count: 4
Nominal Bit Rate(100Mbs): N/A
Specification compliance: sm_media_interface
Vendor Date Code(YYYY-MM-DD Lot): XXXXX
Vendor Name: XXXXX
Vendor OUI: XXXXX
Vendor PN: XXXXX
Vendor Rev: XXXXX
Vendor SN: XXXXX
ChannelMonitorValues:
RX1Power: 2.537dBm
RX2Power: 1.763dBm
RX3Power: 2.683dBm
RX4Power: 2.237dBm
RX5Power: 2.343dBm
RX6Power: 3.252dBm
RX7Power: 2.936dBm
RX8Power: 2.794dBm
TX1Bias: 63.8mA
TX1Power: 1.277dBm
TX2Bias: 60.394mA
TX2Power: 1.871dBm
TX3Bias: 55.23mA
TX3Power: 1.803dBm
TX4Bias: 56.988mA
TX4Power: 1.567dBm
TX5Bias: 60.432mA
TX5Power: 1.826dBm
TX6Bias: 60.468mA
TX6Power: 1.801dBm
TX7Bias: 56.586mA
TX7Power: 1.6dBm
TX8Bias: 57.318mA
TX8Power: 1.552dBm
ChannelThresholdValues:
RxPowerHighAlarm : 4.5dBm
RxPowerHighWarning: 4.0dBm
RxPowerLowAlarm : -6.4dBm
RxPowerLowWarning : -5.901dBm
TxBiasHighAlarm : 125.0mA
TxBiasHighWarning : 120.0mA
TxBiasLowAlarm : 25.0mA
TxBiasLowWarning : 30.0mA
TxPowerHighAlarm : 6.0dBm
TxPowerHighWarning: 5.0dBm
TxPowerLowAlarm : -4.9dBm
TxPowerLowWarning : -3.9dBm
ModuleMonitorValues:
Temperature: 45.645C
Vcc: 3.321Volts
ModuleThresholdValues:
TempHighAlarm : 75.0C
TempHighWarning: 72.0C
TempLowAlarm : -5.0C
TempLowWarning : -2.0C
VccHighAlarm : 3.63Volts
VccHighWarning : 3.465Volts
VccLowAlarm : 2.97Volts
VccLowWarning : 3.135Volts
$ sfputil show eeprom -d -p Ethernet4
Ethernet4: SFP EEPROM detected
Active Firmware: XXXXX
Active application selected code assigned to host lane 1: 5
Active application selected code assigned to host lane 2: 5
Active application selected code assigned to host lane 3: 5
Active application selected code assigned to host lane 4: 5
Active application selected code assigned to host lane 5: 5
Active application selected code assigned to host lane 6: 5
Active application selected code assigned to host lane 7: 5
Active application selected code assigned to host lane 8: 5
Application Advertisement: 400GAUI-4-L C2M (Annex 120G) - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
400GAUI-4-S C2M (Annex 120G) - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
100GAUI-1-L C2M (Annex 120G) - Host Assign (0xff) - 100GBASE-DR (Cl 140) - Media Assign (0xff)
100GAUI-1-S C2M (Annex 120G) - Host Assign (0xff) - 100GBASE-DR (Cl 140) - Media Assign (0xff)
200GAUI-2-L C2M (Annex 120G) - Host Assign (0x55) - Undefined - Media Assign (0x55)
200GAUI-2-S C2M (Annex 120G) - Host Assign (0x55) - Undefined - Media Assign (0x55)
800G L C2M (placeholder) - Host Assign (0x1) - 800GBASE-DR8 (placeholder) - Media Assign (0x1)
CMIS Rev: 5.1
Connector: MPO 2x12
Encoding: N/A
Extended Identifier: Power Class 8 (16.0W Max)
Extended RateSelect Compliance: N/A
Host Lane Count: 2
Identifier: OSFP 8X Pluggable Transceiver
Inactive Firmware: XXXXX
Length Cable Assembly(m): 0.0
Media Interface Technology: 1310 nm EML
Media Lane Count: 2
Module Hardware Rev: 1.0
Nominal Bit Rate(100Mbs): N/A
Specification compliance: sm_media_interface
Supported Max Laser Frequency: N/A
Supported Max TX Power: N/A
Supported Min Laser Frequency: N/A
Supported Min TX Power: N/A
Vendor Date Code(YYYY-MM-DD Lot): XXXXX
Vendor Name: XXXXX
Vendor OUI: XXXXX
Vendor PN: XXXXX
Vendor Rev: XXXXX
Vendor SN: XXXXX