[action] [PR:455] Fetch firmware versions for Cmis Target FW upgrade supported cables (#455) #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onic-net#455) * Fetch firmware versions for Cmis Target FW upgrade supported cables Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Enhanced unit-test for exception handling while reading target firmware version * Addressed PR comments and moved server firmware version info to xcvr_field --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
|
Original PR: #455 |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…0G DR8/FR8 modules (sonic-net#459) * Update xcvrd.py Reset AppSel value for all lanes when setting non default app value * update reset_app_code mock test * Update mock test for reset_app_code * Add new api to reset app code * Fix build failures and add return type * Rename apis * Address review comments rename APIs * remove decommission api from xcvrd * Update xcvrd.py * Update test_xcvrd.py * Update test_xcvrd.py * Update test_xcvrd.py * Update test_xcvrd.py * Add mock test to capture fail case * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Patel patelmi@microsoft.com
Enhanced unit-test for exception handling while reading target firmware version
Addressed PR comments and moved server firmware version info to xcvr_field
Signed-off-by: Mihir Patel patelmi@microsoft.com