Aligning SONiC code with sff8024 spec #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
858ed9c to
7742cce
Compare
keboliu
previously approved these changes
Apr 22, 2024
|
@tshalvi Can you please fix the code coverage check? |
…ment() for applications with missing data
Done |
keboliu
approved these changes
May 6, 2024
prgeor
approved these changes
May 7, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
May 9, 2024
* Updated sff8024.py to align with sff8024 spec (fixes and additions) * A fix for the method of retrieving the application advertisement list from the EEPROM of CMIS modules * Added a unit test to validate the result of get_application_advertisement() for applications with missing data
|
Cherry-pick PR to 202311: #469 |
mssonicbld
pushed a commit
that referenced
this pull request
May 9, 2024
* Updated sff8024.py to align with sff8024 spec (fixes and additions) * A fix for the method of retrieving the application advertisement list from the EEPROM of CMIS modules * Added a unit test to validate the result of get_application_advertisement() for applications with missing data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated sff8024.py to align with the SFF8024 spec by including fixes and additions. Additionally, I resolved an issue in the method responsible for retrieving the application advertisement list from the EEPROM of CMIS modules.
Motivation and Context
We encountered an issue with the application advertisement list retrieved from the get_application_advertisement() method for a specific module. Despite the EEPROM indicating support for 6 applications, the method returned only one application. This discrepancy appeared because the EEPROM's application advertisement list was missing information for the SECOND application. The implementation of get_application_advertisement() in cmis.py would terminate prematurely if information was missing for any application, causing subsequent applications to be overlooked.
To address this issue, this PR introduces two changes:
How Has This Been Tested?
I verified that the missing application in sff8024.py could be successfully detected in the module's EEPROM application advertisement list.
Additional Information (Optional)