Fix issue: copper cable should not display DOM information #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Junchao-Mellanox could you please check the coverage report and see what tests can be added to cover touched functions? |
keboliu
approved these changes
Nov 2, 2022
prgeor
approved these changes
Nov 3, 2022
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Nov 10, 2022
* Fix issue: copper cable should not display DOM information * Improve unit test coverage
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
- Description Fixed SfpStateUpdateTask to not crash during port_cfg dynamic add/del event - Motivation and Context During port breakout, the subprocess invoked by parent xcvrd is crashing indicated in the log - How Has This Been Tested? Apply breakout and check if the subprocess is not crashing Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue: copper cable should not display DOM information
Motivation and Context
For sff8636 and sff8436 cables, there is no DOM information. Need not read DOM data if cable is copper.
How Has This Been Tested?
Manual test
Additional Information (Optional)