Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sonic_sfp Python2 and Python3 compatible #157

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Make sonic_sfp Python2 and Python3 compatible #157

merged 2 commits into from
Jan 5, 2021

Conversation

msosyak
Copy link
Contributor

@msosyak msosyak commented Jan 4, 2021 •
edited by jleveque
Loading

Make _read_eeprom_specific_bytes Python3 and Python2 compatible

Fixes sonic-net/sonic-buildimage#6341

@lgtm-com

This comment has been minimized.

Sign in to view
@msosyak msosyak force-pushed the myron/fix_sonic_sfp branch 3 times, most recently from f63834a to bfcbb2d Compare January 4, 2021 14:30
@msosyak msosyak mentioned this pull request Jan 4, 2021
Merged
4 tasks
jleveque
jleveque suggested changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there is also a call to self.eep_dict.iteritems() on line 746. Can you also please change this to self.eep_dict.items() to make it compatible with both Python 2 and 3?

@jleveque jleveque mentioned this pull request Jan 5, 2021
Closed
@msosyak
Copy link
Contributor Author

msosyak commented Jan 5, 2021

I noticed there is also a call to self.eep_dict.iteritems() on line 746. Can you also please change this to self.eep_dict.items() to make it compatible with both Python 2 and 3?

Done

@msosyak msosyak requested a review from jleveque January 5, 2021 12:55
@jleveque jleveque merged commit 8664efc into sonic-net:master Jan 5, 2021
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
@jleveque
[thermalctld] Refactor to allow for greater unit test coverage; Add m…
8509f43 
…ore unit tests (sonic-net#157)

- Refactor thermalctld to reduce the amount of code in infinite loops, thus allowing us better unit test coverage
- Refactor mock_platform.py such that it inherits from sonic-platform-common in order to ensure it is aligned with the current API definitions (this introduces a test-time dependency on the sonic-platform-common package)
- Increase pytest verbosity to prevent truncation of error messages

- Miscellaneous cleanup:
    - Fixes to grammar
    - Remove unnecessary punctuation from log messages

- Increase overall unit test unit test coverage from 73% to 93%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pmon] xcvrd failed to start on Arista-7260
2 participants
@msosyak @jleveque