Collect db dump from each asic on multi-asic DUT #5326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the motivation for this PR? Db dump use 'redis-dump' to dump files, but on multi-asic DUT, output filename matches with the directory name within the same folder How did you do it? Use "ip netns exec 'namespace' redis-dump" to collect dumps from each asic on multi-asic DUT. How did you verify/test it? Run test in some loops Any platform specific information? Supported testbed topology if it's a new test case?
wangxin
reviewed
Mar 16, 2022
1.Improve some code habits 2.Skip state db dump on 201911 release
wangxin
reviewed
Mar 17, 2022
wangxin
approved these changes
Mar 17, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mannytaheri
reviewed
Mar 17, 2022
| # The issue has been fixed in https://github.com/Azure/sonic-buildimage/pull/5646. | ||
| # However, the fix is not included in 201911 release. So we have to skip STATE_DB on release 201911 | ||
| # to avoid raising exception when dumping the STATE_DB. | ||
| if i == state_db_id and duthosts[0].sonic_release in ['201911']: |
There was a problem hiding this comment.
@xwjiang2021 This line is giving a error as 'i' as undefined. Should this be db_id instead of i
mannytaheri
reviewed
Mar 17, 2022
| db_dump_path = os.path.join(dut_file_path + "/" + namespace, request.module.__name__, request.node.name) | ||
| duthosts.file(path=db_dump_path, state="directory") | ||
| for i in dbs: | ||
| duthosts.shell("ip netns exec {} redis-ducmp -d {} -y -o {}/{}".format(namespace, i, db_dump_path, i)) |
There was a problem hiding this comment.
@xwjiang2021the command should be 'redis-dump' and not 'redis-ducmp'
|
Thanks @mannytaheri for noticing the issues. I'll revert this one and ask the author to submit a new one. |
wangxin
pushed a commit
that referenced
this pull request
Mar 18, 2022
* Collect db dump fromeach asic on multi-asic DUT What is the motivation for this PR? Db dump use 'redis-dump' to dump files, but on multi-asic DUT, output filename matches with the directory name within the same folder How did you do it? Use "ip netns exec 'namespace' redis-dump" to collect dumps from each asic on multi-asic DUT. How did you verify/test it? Run test in some loops Any platform specific information? Supported testbed topology if it's a new test case? * Improve of Collect db dump from each asic on multi-asic DUT 1.Improve some code habits 2.Skip state db dump on 201911 release * Improve: Skip state db dump on 201911 release when add db_id to db set * Improve: Add some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Db dump use 'redis-dump' to dump files, but on multi-asic DUT, output
filename matches with the directory name within the same folder.
How did you do it?
Use "ip netns exec 'namespace' redis-dump" to collect dumps from each
asic on multi-asic DUT.
How did you verify/test it?
Run test in some loops
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation