Collect DB dump when test failed #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the motivation for this PR? Need new test: Inject route flapping and instability How did you do it? 1.choose one route, and ping it continiously 2.withdraw announce some other routes at the same time, to see whether the route stable or not 3. add the completeness level to set loop time How did you verify/test it? Run test in some loops Any platform specific information? Supported testbed topology if it's a new test case?
What is the motivation for this PR? Need new test: Inject route flapping and instability How did you do it? 1.choose one route, and ping it continiously 2.withdraw announce some other routes at the same time, to see whether the route stable or not 3. add the completeness level to set loop time How did you verify/test it? Run test in some loops Any platform specific information? Supported testbed topology if it's a new test case?
What is the motivation for this PR? Collect DB dump when test failed How did you do it? Add a common fixture collect_db_dump set as autouse. When test failed, all of the DBs will be dumped, collected and sent to the test server How did you verify/test it? Failed a test and check the collection Any platform specific information? Supported testbed topology if it's a new test case?
1. fetch to tests/logs/ 2. rm whole log document
wangxin
reviewed
Feb 23, 2022
| # Collect DB dump | ||
| duthosts.file(path=db_dump_path, state="directory") | ||
| for i in dbs: | ||
| duthosts.shell("redis-dump -d {} -y -o {}/{}".format(i, db_dump_path, i)) |
There was a problem hiding this comment.
On duthost, it would be better to generate the dump files to "/tmp".
There was a problem hiding this comment.
OK，I will change the path
tests/conftest.py
Outdated
| When test failed, teardown of this fixture will dump all the DB and collect to the test servers | ||
| ''' | ||
| yield | ||
| collect_db_dump_on_duts(request, duthosts) |
There was a problem hiding this comment.
Usually we add a new line at the end of a file.
1. dut file path: /tmp/db_dump 2. clean .tar.gz in dut
wangxin
approved these changes
Feb 24, 2022
|
this is erroring out in multi-ASIC platform. created #5251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Collect DB dump when test failed
How did you do it?
Add a common fixture collect_db_dump set as autouse. When test failed, all of the DBs will be dumped, collected and sent to the test server
How did you verify/test it?
Failed a test and check the collection
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation