[platform_tests] Ensure reboot-cause string for power-off matches the output on all platforms #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gechiang
reviewed
Aug 28, 2021
| @@ -33,7 +33,7 @@ | |||
| REBOOT_TYPE_POWEROFF: { | |||
| "timeout": 300, | |||
| "wait": 120, | |||
| "cause": "Power Loss", | |||
| "cause": "Power", | |||
There was a problem hiding this comment.
Would this change impact other BRCM platforms such as Arista or Celestica? Have you tried it out on those platforms? Also not sure if this testcase is also ran against MLNX DUTs as well? If so, will need to try out MLNX DUT to ensure it is not impacted...
|
Closing this PR since the reboot-cause will be updated by Dell to address this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
On Dell platforms, the reboot-cause after power-cycle is returned as "Hardware - Other (Power on reset)". Changing script to ensure power-cycle reboot cause is identified correctly
Summary:
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix test_power_off_reboot test case on Dell platform
How did you do it?
Changed reboot-cause string to match the reboot reason returned on multiple platforms
How did you verify/test it?
Validated test_power_off_reboot on 9332
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation