Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPinIP] Update dscp mode to uniform #3374

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

prsunny
Copy link
Contributor

@prsunny prsunny commented Apr 21, 2021

Summary:
Decap test is modified to use dscp mode as uniform instead of pipe. This is based on following PR:

sonic-net/sonic-buildimage#7234

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

dscp mode to be uniform

How did you do it?

How did you verify/test it?

Run test

Any platform specific information?

Applicable to non-mellanox platforms.

Supported testbed topology if it's a new test case?

Documentation

@prsunny prsunny requested a review from a team as a code owner April 21, 2021 01:33
@yxieca
Copy link
Collaborator

yxieca commented Apr 21, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit cfff9c0 into sonic-net:master Apr 22, 2021
@prsunny prsunny deleted the ipinip branch April 22, 2021 20:41
@prsunny
Copy link
Contributor Author

prsunny commented Apr 22, 2021

For test to pass, fix is required for - sonic-net/sonic-buildimage#7216

@antonptashnik
Copy link
Contributor

@prsunny could you please specify why the dscp_mode we check depend on SONiC version ? Are 201811 and 201911 support only pipe and later ones support only uniform ?

saravanansv pushed a commit to saravanansv/sonic-mgmt that referenced this pull request May 6, 2021
@prsunny
Copy link
Contributor Author

prsunny commented May 7, 2021

@prsunny could you please specify why the dscp_mode we check depend on SONiC version ? Are 201811 and 201911 support only pipe and later ones support only uniform ?

That is correct @antonptashnik . You can also refer the PR where the changes is made on 202012 and above. sonic-net/sonic-buildimage#7234

vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants