[mutli-asic][vs]: Add support to test multi-asic vs with four asic and 8 interfaces #2858

SuvarnaMeenakshi · 2021-01-25T20:14:11Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Approach

What is the motivation for this PR?

[multi-asic][vs]: Add new multi-asic vs hwsku with four asics sonic-buildimage#6558 will add new hwsku msft_four_asic_vs which is a 4 asic hwsku with 8 front panel interfaces. With this change, add supporting files to sonic-mgmt so that the new 4 asic hwsku testbed can be brought up.

How did you do it?

Add new t1-lag topo file to support 8 front panel interfaces.
Modify sonic.xml.j2 file to use higher number of vcpus based on the multi-asic hwsku, 6 asic hwsku will require more vcpus.
Add new testbed for msft_four_asic_vs and new DUT vlab-08.
Add a new minigraph for mutli-asic vlab-08 DUT to come up with t1-lag topology.
Start topology service before load_minigraph for multi-asic vs platform.

How did you verify/test it?

Bring up multi-asic vs image with 4-asics testbed using add-topo:
./testbed-cli.sh -t vtestbed.csv -m veos_vtb -k ceos add-topo vms-kvm-four-asic-t1-lag password.txt
Copy the minigraph to virtual switch.
Start topology service (systemctl start topology.service)
load minigraph.
Ensure that all internal and external interfaces are up and all BGP sessions are up.

 admin@vlab-08:~$ show ip bgp summary -d all

IPv4 Unicast Summary:
asic0: BGP router identifier 8.0.0.0, local AS number 65100 vrf-id 0
BGP table version 12754
asic1: BGP router identifier 8.0.0.1, local AS number 65100 vrf-id 0
BGP table version 12775
asic2: BGP router identifier 8.0.0.4, local AS number 65100 vrf-id 0
BGP table version 6398
asic3: BGP router identifier 8.0.0.5, local AS number 65100 vrf-id 0
BGP table version 6398
RIB entries 51176, using 9416384 bytes of memory
Peers 14, using 292880 KiB of memory
Peer groups 12, using 768 bytes of memory


Neighbhor      V     AS    MsgRcvd    MsgSent    TblVer    InQ    OutQ  Up/Down      State/PfxRcd  NeighborName
-----------  ---  -----  ---------  ---------  --------  -----  ------  ---------  --------------  --------------
10.0.0.1       4  65200       3774       6963         0      0       0  00:29:50             6370  ARISTA01T2
10.0.0.5       4  65200       3775       6914         0      0       0  00:29:46             6370  ARISTA03T2
10.0.0.33      4  64001        603       6980         0      0       0  00:29:54                3  ARISTA01T0
10.0.0.35      4  64002        603       6978         0      0       0  00:29:52                3  ARISTA02T0
10.0.0.37      4  64003        604       6976         0      0       0  00:29:51                4  ARISTA03T0
10.0.0.39      4  64004        602       6978         0      0       0  00:29:48                3  ARISTA04T0
10.1.0.0       4  65100       3769       3765         0      0       0  00:28:32             6398  ASIC2
10.1.0.1       4  65100       3766       3770         0      0       0  00:28:36             6377  ASIC0
10.1.0.2       4  65100       3768       3763         0      0       0  00:28:27             6398  ASIC3
10.1.0.3       4  65100       3765       3770         0      0       0  00:28:34             6377  ASIC0
10.1.0.4       4  65100       3770        586         0      0       0  00:28:34             6398  ASIC2
10.1.0.5       4  65100        587       3770         0      0       0  00:28:36               21  ASIC1
10.1.0.6       4  65100       3770        586         0      0       0  00:28:35             6398  ASIC3
10.1.0.7       4  65100        588       3772         0      0       0  00:28:40               21  ASIC1
admin@vlab-08:~$ show platform summary
Platform: x86_64-kvm_x86_64-r0
HwSKU: msft_four_asic_vs
ASIC: vs
ASIC Count: 4

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

with 8 front panel interfaces. Add 8 interfaces topo files. Modify number of asics for msft_multi_asic_vs hwsku to 4. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

t1-8-lag topology. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

lguohan · 2021-02-03T17:31:31Z

ansible/vtestbed.csv

@@ -4,4 +4,4 @@ vms-kvm-t0-64,vms6-1,t0-64,docker-ptf,ptf-01,10.250.0.102/24,fec0::ffff:afa:2/64
 vms-kvm-t1-lag,vms6-2,t1-lag,docker-ptf,ptf-02,10.250.0.106/24,fec0::ffff:afa:6/64,server_1,VM0104,[vlab-03],Tests virtual switch vm
 vms-kvm-t0-2,vms6-3,t0,docker-ptf,ptf-03,10.250.0.108/24,fec0::ffff:afa:8/64,server_1,VM0104,[vlab-04],Tests virtual switch vm
 vms-kvm-dual-t0,vms6-4,dualtor,docker-ptf,ptf-04,10.250.0.109/24,fec0::ffff:afa:9/64,server_1,VM0108,[vlab-05;vlab-06],Dual-TOR testbed
-vms-kvm-multi-asic-t1-lag,vms6-4,t1-64-lag,docker-ptf,ptf-05,10.250.0.110/24,fec0::ffff:afa:a/64,server_1,VM0104,[vlab-07],Tests multi-asic virtual switch vm
+vms-kvm-multi-asic-t1-lag,vms6-4,t1-8-lag,docker-ptf,ptf-05,10.250.0.110/24,fec0::ffff:afa:a/64,server_1,VM0104,[vlab-07],Tests multi-asic virtual switch vm


i do not think we should remove t1-64-lag

Modified to add a new DUT/testbed with a new hwsku msft_four_asic_vs added using: sonic-net/sonic-buildimage#6558

lguohan · 2021-02-03T17:32:16Z

ansible/veos_vtb

@@ -113,7 +114,7 @@ all:
          type: kvm
          hwsku: msft_multi_asic_vs
          serial_port: 9005
-          num_asics: 6
+          num_asics: 4


this should be kept.

I am ok to introduce a new one since in the long term we need to run vs test with 6 asics.

Added a new hwsku for 4-asics and kept the 6-asic sku as is.

with hwsku msft_four_asic_vs. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Minor fixes. Change the number of vcpus based on the multi-asic hwsku. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Add flag to specify if topology service has to be started before loading minigraph. start topology service before loading minigraph for multi-asic vs platform. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

arlakshm

as comments

ansible/lab

arlakshm · 2021-02-23T18:35:58Z

ansible/lab

+  vars:
+    hwsku: msft_four_asic_vs
+    iface_speed: 40000
+    num_asics: 4


Please add the frontend asic attribute as well
frontend_asics: [2,3]

Updated to [0,1].

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

…atform (#3025) What is the motivation for this PR? Minigraph template changes to support minigraph generation for multi-asic platform. How did you do it? Pre-requisite: #3024 Add changes to minigraph templates to use the new data structure asic_topo_config and include asic topology. How did you verify/test it? With the changes in PR#3024: Bring up four-asic VS testbed using the changes in: #2858 testbed-cli.sh -t vtestbed.csv -m veos_vtb -k ceos add-topo vms-kvm-four-asic-t1-lag password.txt Deploy minigraph using: ./testbed-cli.sh -t vtestbed.csv -m veos_vtb deploy-mg vms-kvm-four-asic-t1-lag lab password.txt With this, minigraph should be generated and deployed on the multi-asic VS DUT. Check all interfaces status and BGP status.

SuvarnaMeenakshi added 3 commits January 24, 2021 19:24

[masic][vs]: Support to test a four asic virtual switch

a974503

with 8 front panel interfaces. Add 8 interfaces topo files. Modify number of asics for msft_multi_asic_vs hwsku to 4. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

[multi-asic][vs]: Modify topo of msft_multi_asic_vs testbed.`

2236135

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

[multi-asic][vs]: Add minigraph for multi-asic vs for

4986dbd

t1-8-lag topology. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

SuvarnaMeenakshi requested review from wangxin, judyjoseph, arlakshm and abdosi January 25, 2021 20:14

yxieca approved these changes Jan 28, 2021

View reviewed changes

wangxin approved these changes Jan 29, 2021

View reviewed changes

arlakshm approved these changes Jan 29, 2021

View reviewed changes

lguohan reviewed Feb 3, 2021

View reviewed changes

SuvarnaMeenakshi added 3 commits February 15, 2021 13:53

[multi-asic]: Add a new testbed to bring up multi-asic vs

6c3c1ee

with hwsku msft_four_asic_vs. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Changes to support new four asics multi_asic_vs hwsku.

ad48a0b

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Merge remote-tracking branch 'origin/master' into masic_4_asic_vs

7f95ee7

SuvarnaMeenakshi requested a review from a team as a code owner February 17, 2021 20:43

SuvarnaMeenakshi added 2 commits February 17, 2021 12:47

Add new minigraph for vlab-08 DUT.

5f6f898

Minor fixes. Change the number of vcpus based on the multi-asic hwsku. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Remove whitespace.

5b089be

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

SuvarnaMeenakshi requested review from wangxin and arlakshm February 23, 2021 00:53

Correct the memory and vcpu requirement for multi-asic vs.

398fecd

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

This was referenced Feb 23, 2021

[multi-asic][minigraph]: Add changes to support minigraph generation for multi-asic #3024

Merged

[multi-asic][minigraph]: Modify minigraph templates for multi-asic platform #3025

Merged

SuvarnaMeenakshi added 3 commits February 22, 2021 23:27

Add changes in inventory file to specify the number of asics.

64b04ac

Add flag to specify if topology service has to be started before loading minigraph. start topology service before loading minigraph for multi-asic vs platform. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Merge remote-tracking branch 'origin/master' into masic_4_asic_vs

0017c12

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

Fix IP address of vlab-07 DUT.

ba3b0aa

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

arlakshm reviewed Feb 23, 2021

View reviewed changes

Add frontend_asics list in inventory file.

a17aa92

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

arlakshm approved these changes Feb 23, 2021

View reviewed changes

Fix IP address of vlab-07 and vlab-08 DUT and ptf-dockers.

18a24bb

Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>

SuvarnaMeenakshi requested a review from arlakshm February 23, 2021 21:45

arlakshm approved these changes Feb 23, 2021

View reviewed changes

SuvarnaMeenakshi merged commit 2e6847c into sonic-net:master Feb 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mutli-asic][vs]: Add support to test multi-asic vs with four asic and 8 interfaces #2858

[mutli-asic][vs]: Add support to test multi-asic vs with four asic and 8 interfaces #2858

SuvarnaMeenakshi commented Jan 25, 2021 •

edited

Loading

lguohan Feb 3, 2021

SuvarnaMeenakshi Feb 17, 2021

lguohan Feb 3, 2021

SuvarnaMeenakshi Feb 17, 2021

arlakshm left a comment

arlakshm Feb 23, 2021

SuvarnaMeenakshi Feb 23, 2021

[mutli-asic][vs]: Add support to test multi-asic vs with four asic and 8 interfaces #2858

[mutli-asic][vs]: Add support to test multi-asic vs with four asic and 8 interfaces #2858

Conversation

SuvarnaMeenakshi commented Jan 25, 2021 • edited Loading

Description of PR

Type of change

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

lguohan Feb 3, 2021

Choose a reason for hiding this comment

SuvarnaMeenakshi Feb 17, 2021

Choose a reason for hiding this comment

lguohan Feb 3, 2021

Choose a reason for hiding this comment

SuvarnaMeenakshi Feb 17, 2021

Choose a reason for hiding this comment

arlakshm left a comment

Choose a reason for hiding this comment

arlakshm Feb 23, 2021

Choose a reason for hiding this comment

SuvarnaMeenakshi Feb 23, 2021

Choose a reason for hiding this comment

SuvarnaMeenakshi commented Jan 25, 2021 •

edited

Loading