-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add team docker and config files and interfaces file #23
Conversation
@@ -8,7 +8,17 @@ | |||
mode=0644 | |||
register: if_copy | |||
tags: network,unsafe | |||
when: sonic_version == "v2" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove 'when' clause? #Closed
#Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is in sonicv2 folder so no need to have this #Closed
owner=root | ||
group=root | ||
mode=0644 | ||
register: if_copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it going to overwrite previous 'if_copy'?
owner=root | ||
group=root | ||
mode=644 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restart container after template?
@@ -33,3 +43,6 @@ | |||
|
|||
- include: quagga.yml | |||
tags: quagga,unsafe | |||
|
|||
- include: team.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
team [](start = 11, length = 4)
rename to teamd?
@@ -0,0 +1,10 @@ | |||
- name: Start the team docker container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
teamd might be a better name.
- name: Start the team docker container | ||
include: sonicdocker.yml | ||
vars: | ||
docker_container: team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
team [](start = 22, length = 4)
rename to teamd?
# | ||
{% block banner %} | ||
# =========== Managed by Ansible DO NOT EDIT! ======================== | ||
# generated by templates/interfaces.j2 using minigraph_facts.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lag_interfaces.j2
{% block banner %} | ||
# =========== Managed by Ansible DO NOT EDIT! ======================== | ||
# generated by templates/interfaces.j2 using minigraph_facts.py | ||
# file: vlan_interfaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vlan_interfaces [](start = 8, length = 15)
lag_interfaces
{% endblock %} | ||
# | ||
{% block lag_interface %} | ||
# The switch VLAN interfaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The switch VLAN interfaces [](start = 2, length = 26)
switch VLAN interfaces?
address {{ interface['addr'] }} | ||
netmask {{ interface['mask'] }} | ||
{% endfor %} | ||
{% endblock lag_interface %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need bridges_ports here? Is this for lag for vlan?
owner=root | ||
group=root | ||
mode=0644 | ||
register: if_copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we seperate this file with the interfaces file?
🕐 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many questions, please address.
close this and open #69. |
No description provided.