Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add team docker and config files and interfaces file #23

Closed
wants to merge 3 commits into from

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Oct 18, 2016

No description provided.

@@ -8,7 +8,17 @@
mode=0644
register: if_copy
tags: network,unsafe
when: sonic_version == "v2"

Copy link
Contributor

@qiluo-msft qiluo-msft Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove 'when' clause? #Closed
#Closed

Copy link
Contributor Author

@stcheng stcheng Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is in sonicv2 folder so no need to have this #Closed

owner=root
group=root
mode=0644
register: if_copy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it going to overwrite previous 'if_copy'?

owner=root
group=root
mode=644

Copy link
Contributor

@qiluo-msft qiluo-msft Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restart container after template?

@@ -33,3 +43,6 @@

- include: quagga.yml
tags: quagga,unsafe

- include: team.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

team [](start = 11, length = 4)

rename to teamd?

@@ -0,0 +1,10 @@
- name: Start the team docker container
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teamd might be a better name.

- name: Start the team docker container
include: sonicdocker.yml
vars:
docker_container: team
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

team [](start = 22, length = 4)

rename to teamd?

@lguohan
Copy link
Contributor

lguohan commented Oct 19, 2016

can you provide minigraph examples?


Refers to: ansible/group_vars/sonic_latest/package_versions.yml:25 in 72618ef. [](commit_id = 72618ef, deletion_comment = False)

#
{% block banner %}
# =========== Managed by Ansible DO NOT EDIT! ========================
# generated by templates/interfaces.j2 using minigraph_facts.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lag_interfaces.j2

{% block banner %}
# =========== Managed by Ansible DO NOT EDIT! ========================
# generated by templates/interfaces.j2 using minigraph_facts.py
# file: vlan_interfaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vlan_interfaces [](start = 8, length = 15)

lag_interfaces

{% endblock %}
#
{% block lag_interface %}
# The switch VLAN interfaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The switch VLAN interfaces [](start = 2, length = 26)

switch VLAN interfaces?

address {{ interface['addr'] }}
netmask {{ interface['mask'] }}
{% endfor %}
{% endblock lag_interface %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need bridges_ports here? Is this for lag for vlan?

owner=root
group=root
mode=0644
register: if_copy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we seperate this file with the interfaces file?

@lguohan
Copy link
Contributor

lguohan commented Oct 19, 2016

🕐

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many questions, please address.

@stcheng
Copy link
Contributor Author

stcheng commented Dec 15, 2016

close this and open #69.

@stcheng stcheng closed this Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants