Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test gap] Add a new case to check caclmgrd syslog #17143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZhaohuiS
Copy link
Contributor

@ZhaohuiS ZhaohuiS commented Feb 25, 2025

Description of PR

Summary:
Fixes # (issue)
To address #16548.
The issue sonic-net/sonic-buildimage#21290, the issue of INFO level logs disappear in caclmgrd was reported after the commit got merged months later.
We need a test case to help us report this kind of issue earlier.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

A new test case to check if INFO logs of caclmgrd was printed into syslog successfully.

How did you do it?

  1. rotate syslog
  2. restart caclmgrd
  3. check if iptables syslog existing in syslog file
  4. Check if iptables rules are applied successfully in the output of systemctl status caclmgrd

How did you verify/test it?

Run the new test case on the testbed

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
@mssonicbld
Copy link
Collaborator

/azp run

@ZhaohuiS ZhaohuiS requested review from matthew-soulsby and Copilot and removed request for matthew-soulsby February 25, 2025 05:41
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants