[SmartSwitch] Add tests for reboot of a smart switch #16566
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
lgtm |
|
@congh-nvidia, @JibinBao pleae review |
| Returns: | ||
| True if the current node is a SmartSwitch, else False | ||
| """ | ||
| return "DPUS" in self.facts |
There was a problem hiding this comment.
Can you give an example for self.facts?
| """ | ||
| return "DPUS" in self.facts | ||
|
|
||
| def is_dpu(self): |
There was a problem hiding this comment.
For dpu, we have a dpuhosts and dpuhost fixture, if you want to operate the dpu, maybe you can use dpuhosts
#15695
| @param dpu_id: DPU ID | ||
| @param dpu_name: DPU name | ||
| """ | ||
| from tests.common.reboot import REBOOT_TYPE_HISTOYR_QUEUE, sync_reboot_history_queue_with_dut |
There was a problem hiding this comment.
Can we combine it with line 7 'from tests.common.reboot import reboot_ss_ctrl_dict as reboot_dict'
| @param dpu_name: Name of the DPU | ||
| @param dut_datetime: Datetime of DUT when reboot initiated | ||
| """ | ||
| pytest_assert(wait_until(120, 30, 0, check_dpu_ping_status, duthost, dpu_ip), |
There was a problem hiding this comment.
After reboot dpu, is 120s enough for the dpu to be up?
| """ | ||
| duthost = duthosts[enum_rand_one_per_hwsku_hostname] | ||
|
|
||
| for index in range(num_dpu_modules): |
There was a problem hiding this comment.
Since we have 4 or 8 dpus for one smartswitch, perform_and_check_reboot might take more than 3 minutes for one dpu. Can we tests the dpus in parallel so that we can save much test running time?
Description of PR
Summary: Add sonic-mgmt tests for reboot of a smart switch and individual DPUs
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Supporting different types of reboots for smart switch
How did you do it?
How did you verify/test it?
Any platform specific information?
-Smartswitch topology
Supported testbed topology if it's a new test case?
Documentation