feat: add wait_for_bgp option to reboot #16542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@cyw233 PR conflicts with 202411 branch |
|
@cyw233 PR conflicts with 202405 branch |
cyw233
added a commit
to cyw233/sonic-mgmt
that referenced
this pull request
Jan 16, 2025
Description of PR The reboot process for chassis will need longer time to wait for the BGP to be established. For example, the acl/test_acl.py can be flaky if we are not waiting BGP long enough. Therefore, we are introducing wait_for_bgp option to the reboot() function. Summary: Fixes # (issue) Microsoft ADO 30862178 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? We found that tests like acl/test_acl.py can be flaky if we are not waiting for BGP long enough on chassis after reboot. Therefore, we want to mimic what we have in config_reload() to also introduce the wait_for_bgp option to the reboot() function. How did you do it? How did you verify/test it? I ran the updated acl test code and can make sure it's working well. co-authorized by: jianquanye@microsoft.com
11 tasks
|
Cherry-pick PR to 202405: #16562 |
cyw233
added a commit
to cyw233/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
Description of PR The reboot process for chassis will need longer time to wait for the BGP to be established. For example, the acl/test_acl.py can be flaky if we are not waiting BGP long enough. Therefore, we are introducing wait_for_bgp option to the reboot() function. Summary: Fixes # (issue) Microsoft ADO 30862178 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? We found that tests like acl/test_acl.py can be flaky if we are not waiting for BGP long enough on chassis after reboot. Therefore, we want to mimic what we have in config_reload() to also introduce the wait_for_bgp option to the reboot() function. How did you do it? How did you verify/test it? I ran the updated acl test code and can make sure it's working well. co-authorized by: jianquanye@microsoft.com
11 tasks
|
Cherry-pick PR to 202411: #16563 |
yejianquan
pushed a commit
that referenced
this pull request
Jan 17, 2025
Description of PR The reboot process for chassis will need longer time to wait for the BGP to be established. For example, the acl/test_acl.py can be flaky if we are not waiting BGP long enough. Therefore, we are introducing wait_for_bgp option to the reboot() function. Summary: Fixes # (issue) Microsoft ADO 30862178 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? We found that tests like acl/test_acl.py can be flaky if we are not waiting for BGP long enough on chassis after reboot. Therefore, we want to mimic what we have in config_reload() to also introduce the wait_for_bgp option to the reboot() function. How did you do it? How did you verify/test it? I ran the updated acl test code and can make sure it's working well. co-authorized by: jianquanye@microsoft.com
yejianquan
pushed a commit
that referenced
this pull request
Jan 17, 2025
Description of PR The reboot process for chassis will need longer time to wait for the BGP to be established. For example, the acl/test_acl.py can be flaky if we are not waiting BGP long enough. Therefore, we are introducing wait_for_bgp option to the reboot() function. Summary: Fixes # (issue) Microsoft ADO 30862178 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? We found that tests like acl/test_acl.py can be flaky if we are not waiting for BGP long enough on chassis after reboot. Therefore, we want to mimic what we have in config_reload() to also introduce the wait_for_bgp option to the reboot() function. How did you do it? How did you verify/test it? I ran the updated acl test code and can make sure it's working well. co-authorized by: jianquanye@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The reboot process for chassis will need longer time to wait for the BGP to be established. For example, the
acl/test_acl.pycan be flaky if we are not waiting BGP long enough. Therefore, we are introducingwait_for_bgpoption to thereboot()function.Summary:
Fixes # (issue) Microsoft ADO 30862178
Type of change
Back port request
Approach
What is the motivation for this PR?
We found that tests like
acl/test_acl.pycan be flaky if we are not waiting for BGP long enough on chassis after reboot. Therefore, we want to mimic what we have inconfig_reload()to also introduce thewait_for_bgpoption to thereboot()function.How did you do it?
How did you verify/test it?
I ran the updated acl test code and can make sure it's working well.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation