Add check to see if bgp sessions are up before proceeding with the tests #15921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @abdosi @yejianquan |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 6, 2024
…sts (sonic-net#15921) Description of PR After acl reboot, we check for critical process status and interface status but do not check to see if all BGP sessions are up or not. Sometimes testcases fail because packet is not received, this is because BGP sessions are not yet up and fail the ACL tests for the wrong reasons. This check will make sure that BGP sessions are up before continuing with the ACL tests Instead of checking only for T1 and M0 profile, checking it for all profiles Summary: Fixes # (issue) Approach What is the motivation for this PR? After acl reboot, we check for critical process status and interface status but do not check to see if all BGP sessions are up or not. Sometimes testcases fail because packet is not received, this is because BGP sessions are not yet up and fail the ACL tests for the wrong reasons. How did you do it? This check will make sure that BGP sessions are up before continuing with the ACL tests How did you verify/test it? On T2 profile for Cisco 8808 chassis Any platform specific information? No co-authorized by: jianquanye@microsoft.com
|
Cherry-pick PR to 202405: #15926 |
Merged
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 6, 2024
…sts (#15921) Description of PR After acl reboot, we check for critical process status and interface status but do not check to see if all BGP sessions are up or not. Sometimes testcases fail because packet is not received, this is because BGP sessions are not yet up and fail the ACL tests for the wrong reasons. This check will make sure that BGP sessions are up before continuing with the ACL tests Instead of checking only for T1 and M0 profile, checking it for all profiles Summary: Fixes # (issue) Approach What is the motivation for this PR? After acl reboot, we check for critical process status and interface status but do not check to see if all BGP sessions are up or not. Sometimes testcases fail because packet is not received, this is because BGP sessions are not yet up and fail the ACL tests for the wrong reasons. How did you do it? This check will make sure that BGP sessions are up before continuing with the ACL tests How did you verify/test it? On T2 profile for Cisco 8808 chassis Any platform specific information? No co-authorized by: jianquanye@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
After acl reboot, we check for critical process status and interface status but do not check to see if all BGP sessions are up or not. Sometimes testcases fail because packet is not received, this is because BGP sessions are not yet up and fail the ACL tests for the wrong reasons.
This check will make sure that BGP sessions are up before continuing with the ACL tests
Instead of checking only for T1 and M0 profile, checking it for all profiles
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
After acl reboot, we check for critical process status and interface status but do not check to see if all BGP sessions are up or not. Sometimes testcases fail because packet is not received, this is because BGP sessions are not yet up and fail the ACL tests for the wrong reasons.
How did you do it?
This check will make sure that BGP sessions are up before continuing with the ACL tests
How did you verify/test it?
On T2 profile for Cisco 8808 chassis
Any platform specific information?
No
Supported testbed topology if it's a new test case?
Documentation