Disable pfcwd for pfc_lossless. #15887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 6, 2024
Description of PR The pfc lossless test assume pfcwd is disabled. But this test: test_pfc_pause_multi_lossless_prio is not provided the fixture: "disable_pfcwd" which is used by all other tests in the same script. This causes this test to fail since the pfcwd is triggered and packets are dropped. Approach What is the motivation for this PR? this test is failing with this error: Failed: Total TX bytes 841563217920 should be smaller than DUT buffer size 67108864 How did you do it? Disable pfcwd during the test using the fixture, that is already used by other tests in the same script. How did you verify/test it? Ran it on my TB: co-authorized by: jianquanye@microsoft.com
|
Cherry-pick PR to 202405: #15928 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 6, 2024
Description of PR The pfc lossless test assume pfcwd is disabled. But this test: test_pfc_pause_multi_lossless_prio is not provided the fixture: "disable_pfcwd" which is used by all other tests in the same script. This causes this test to fail since the pfcwd is triggered and packets are dropped. Approach What is the motivation for this PR? this test is failing with this error: Failed: Total TX bytes 841563217920 should be smaller than DUT buffer size 67108864 How did you do it? Disable pfcwd during the test using the fixture, that is already used by other tests in the same script. How did you verify/test it? Ran it on my TB: co-authorized by: jianquanye@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The pfc lossless test assume pfcwd is disabled. But this test: test_pfc_pause_multi_lossless_prio is not provided the fixture: "disable_pfcwd" which is used by all other tests in the same script. This causes this test to fail since the pfcwd is triggered and packets are dropped.
Type of change
Back port request
Approach
What is the motivation for this PR?
this test is failing with this error:
Failed: Total TX bytes 841563217920 should be smaller than DUT buffer size 67108864How did you do it?
Disable pfcwd during the test using the fixture, that is already used by other tests in the same script.
How did you verify/test it?
Ran it on my TB:
@sdszhang , @auspham : FYI.