Fix issue "createEntry: Invalid port interface" #15863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
alpeshspatel
approved these changes
Dec 6, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 6, 2024
Description of PR Summary: Fixes # (issue) https://miggbo.atlassian.net/browse/MIGSOFTWAR-19536 2024 Nov 25 20:11:42.889000 yy39top-lc4 ERR swss0#orchagent: :- createEntry: Invalid port interface Ethernet-BP384 2024 Nov 25 20:11:42.889000 yy39top-lc4 ERR swss0#orchagent: :- doTask: Failed to process PFC watchdog SET task, invalid entry Approach What is the motivation for this PR? Fix issue of "createEntry: Invalid port interface" when running script snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py. How did you do it? Fix the sequence of config files when doing config load. How did you verify/test it? Verified the case on T2 ixia testbed. ----------------------- generated xml file: /run_logs/ixia/18470/2024-12-04-00-38-12/tr_2024-12-04-00-38-12.xml ----------------------- INFO:root:Can not get Allure report URL. Please check logs ======================================================= short test summary info ======================================================= PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_port_toggle[multidut_port_info0] ============================================== 1 passed, 4 warnings in 698.79s (0:11:38) ============================================== sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ cisco@yy39top-lc4:~$ sudo cat /var/log/syslog | grep "start-LogAnalyzer" 2024 Dec 4 00:35:43.561644 yy39top-lc4 INFO start-LogAnalyzer-test_ecn_marking_port_toggle[multidut_port_info0].2024-12-04-00:39:16 2024 Dec 4 00:40:54.158423 yy39top-lc4 INFO python[176673]: ansible-extract_log Invoked with directory=/var/log file_prefix=syslog start_string=start-LogAnalyzer-test_ecn_marking_port_toggle[multidut_port_info0].2024-12-04-00:39:16 target_filename=/tmp/syslog cisco@yy39top-lc4:~$ sudo cat /var/log/syslog | grep "Invalid port interface" cisco@yy39top-lc4:~$ sudo cat /var/log/syslog | grep "_raw_params=config load" 2024 Dec 4 00:40:39.667553 yy39top-lc4 INFO python[175350]: ansible-ansible.legacy.command Invoked with _raw_params=config load 1733273048.975233_pfcwd_None.json,1733273048.975233_pfcwd_asic0.json,1733273048.975233_pfcwd_asic1.json,1733273048.975233_pfcwd_asic2.json -y _uses_shell=True warn=False stdin_add_newline=True strip_empty_ends=True argv=None chdir=None executable=None creates=None removes=None stdin=None cisco@yy39top-lc4:~$ Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
|
Cherry-pick PR to 202405: #15929 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 6, 2024
Description of PR Summary: Fixes # (issue) https://miggbo.atlassian.net/browse/MIGSOFTWAR-19536 2024 Nov 25 20:11:42.889000 yy39top-lc4 ERR swss0#orchagent: :- createEntry: Invalid port interface Ethernet-BP384 2024 Nov 25 20:11:42.889000 yy39top-lc4 ERR swss0#orchagent: :- doTask: Failed to process PFC watchdog SET task, invalid entry Approach What is the motivation for this PR? Fix issue of "createEntry: Invalid port interface" when running script snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py. How did you do it? Fix the sequence of config files when doing config load. How did you verify/test it? Verified the case on T2 ixia testbed. ----------------------- generated xml file: /run_logs/ixia/18470/2024-12-04-00-38-12/tr_2024-12-04-00-38-12.xml ----------------------- INFO:root:Can not get Allure report URL. Please check logs ======================================================= short test summary info ======================================================= PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_port_toggle[multidut_port_info0] ============================================== 1 passed, 4 warnings in 698.79s (0:11:38) ============================================== sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ cisco@yy39top-lc4:~$ sudo cat /var/log/syslog | grep "start-LogAnalyzer" 2024 Dec 4 00:35:43.561644 yy39top-lc4 INFO start-LogAnalyzer-test_ecn_marking_port_toggle[multidut_port_info0].2024-12-04-00:39:16 2024 Dec 4 00:40:54.158423 yy39top-lc4 INFO python[176673]: ansible-extract_log Invoked with directory=/var/log file_prefix=syslog start_string=start-LogAnalyzer-test_ecn_marking_port_toggle[multidut_port_info0].2024-12-04-00:39:16 target_filename=/tmp/syslog cisco@yy39top-lc4:~$ sudo cat /var/log/syslog | grep "Invalid port interface" cisco@yy39top-lc4:~$ sudo cat /var/log/syslog | grep "_raw_params=config load" 2024 Dec 4 00:40:39.667553 yy39top-lc4 INFO python[175350]: ansible-ansible.legacy.command Invoked with _raw_params=config load 1733273048.975233_pfcwd_None.json,1733273048.975233_pfcwd_asic0.json,1733273048.975233_pfcwd_asic1.json,1733273048.975233_pfcwd_asic2.json -y _uses_shell=True warn=False stdin_add_newline=True strip_empty_ends=True argv=None chdir=None executable=None creates=None removes=None stdin=None cisco@yy39top-lc4:~$ Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
9 tasks
yejianquan
pushed a commit
that referenced
this pull request
Jan 1, 2025
…d and enable_pfcwd functions. (#16176) Description of PR Summary: Even after #15863, the problem is still seen in RP. The issue is that the sort() function only sorts alphabetically, not numerically. So we need to use natsort module instead of normal sort() in these functions. Approach What is the motivation for this PR? Seeing a lot of loganalyzer messages, but in RP only. How did you do it? Change sort to natsort(). How did you verify/test it? Running in my TB, I don't see the LA error anymore. Any platform specific information? T2 mAsic only. co-authorized by: jianquanye@microsoft.com
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 1, 2025
…d and enable_pfcwd functions. (sonic-net#16176) Description of PR Summary: Even after sonic-net#15863, the problem is still seen in RP. The issue is that the sort() function only sorts alphabetically, not numerically. So we need to use natsort module instead of normal sort() in these functions. Approach What is the motivation for this PR? Seeing a lot of loganalyzer messages, but in RP only. How did you do it? Change sort to natsort(). How did you verify/test it? Running in my TB, I don't see the LA error anymore. Any platform specific information? T2 mAsic only. co-authorized by: jianquanye@microsoft.com
9 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 2, 2025
…d and enable_pfcwd functions. (#16176) Description of PR Summary: Even after #15863, the problem is still seen in RP. The issue is that the sort() function only sorts alphabetically, not numerically. So we need to use natsort module instead of normal sort() in these functions. Approach What is the motivation for this PR? Seeing a lot of loganalyzer messages, but in RP only. How did you do it? Change sort to natsort(). How did you verify/test it? Running in my TB, I don't see the LA error anymore. Any platform specific information? T2 mAsic only. co-authorized by: jianquanye@microsoft.com
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 2, 2025
…d and enable_pfcwd functions. (sonic-net#16176) Description of PR Summary: Even after sonic-net#15863, the problem is still seen in RP. The issue is that the sort() function only sorts alphabetically, not numerically. So we need to use natsort module instead of normal sort() in these functions. Approach What is the motivation for this PR? Seeing a lot of loganalyzer messages, but in RP only. How did you do it? Change sort to natsort(). How did you verify/test it? Running in my TB, I don't see the LA error anymore. Any platform specific information? T2 mAsic only. co-authorized by: jianquanye@microsoft.com
9 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 2, 2025
…d and enable_pfcwd functions. (#16176) Description of PR Summary: Even after #15863, the problem is still seen in RP. The issue is that the sort() function only sorts alphabetically, not numerically. So we need to use natsort module instead of normal sort() in these functions. Approach What is the motivation for this PR? Seeing a lot of loganalyzer messages, but in RP only. How did you do it? Change sort to natsort(). How did you verify/test it? Running in my TB, I don't see the LA error anymore. Any platform specific information? T2 mAsic only. co-authorized by: jianquanye@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
https://miggbo.atlassian.net/browse/MIGSOFTWAR-19536
2024 Nov 25 20:11:42.889000 yy39top-lc4 ERR swss0#orchagent: :- createEntry: Invalid port interface Ethernet-BP384
2024 Nov 25 20:11:42.889000 yy39top-lc4 ERR swss0#orchagent: :- doTask: Failed to process PFC watchdog SET task, invalid entry
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix issue of "createEntry: Invalid port interface" when running script snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py.
How did you do it?
Fix the sequence of config files when doing config load.
How did you verify/test it?
Verified the case on T2 ixia testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation