[testbed-cli-add-topo] Code change for deploying testbed with peers on multiple servers #15547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1nda
commented
Nov 14, 2024
| continue | ||
| elif server_index != -1: | ||
| offset = int(offset.split(',')[1]) | ||
| if base + offset >= len(values): # if the vm is not defined in iventory files veos |
Blueve
reviewed
Nov 14, 2024
| return yaml.safe_load(f) | ||
| _ret = yaml.safe_load(f) | ||
| if server_index != -1: | ||
| for _name, _attr in _ret['topology']['VMs'].items(): |
There was a problem hiding this comment.
So it is a kind of intrusive schema change, is possible to do it smartly? Why user input is required for VM distribution?
Blueve
reviewed
Nov 14, 2024
| @@ -88,7 +102,7 @@ def first_n_elements(values, num): | |||
| return values[0:int(num)] | |||
|
|
|||
|
|
|||
| def filter_vm_targets(values, topology, vm_base): | |||
| def filter_vm_targets(values, topology, vm_base, server_index=-1): | |||
| """ | |||
| This function takes a list of host VMs as parameter 'values' and then extract a list of host VMs | |||
There was a problem hiding this comment.
Please update the doc comment as well.
8 tasks
wangxin
pushed a commit
that referenced
this pull request
Jan 20, 2025
…ing testbed with peers on multiple servers (#15643) In PR #15547, we define server index in topology file which make topology file and testbed yaml file is coupled. To decouple them, in new design #15395, we remove server index in topology file and add dut_interfaces in testbed yaml, so there is no more change on topology file schema. What is the motivation for this PR? Decouple topology file and testbed file in design. How did you do it? Record all information in testbed schema How did you verify/test it? Deploy testbed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
This is add-topo implementation for PR: #15395
Type of change
Back port request
Approach
What is the motivation for this PR?
When deploying a testbed with a great number of virtual ceos neighbors, we will create ceos containers on same server, however, the server doesn't have infinite resources such as memory to deploy that.
To leverage the servers instead of single server, we proposal this design for deploying testbed with multiple servers.
How did you do it?
Extend current script and ansible file to support add-topo operation for multi-servers deployment.
How did you verify/test it?
Add-topo and remove-topo on testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation