Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202405] Update platform sfp tests to skip dom check for sfp with flat memory #15141

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

JibinBao
Copy link
Contributor

Description of PR

  1. Sfp eeprom with option dom is not working on Xcvrs with flat memory. There is a relevant PR:[SfpUtil] sfp eeprom with option dom is not working on Xcvrs with flat memory sonic-utilities#3385. Therefore, skip dom check for sfp with flat memory. Also, fix sonic mgmt issue: [Bug]: test_xcvr_info_in_db should skip the DOM_SENSOR check for DAC cables or Flat memory due to design change #12981
  2. Skip test ports with flat memory for test_get_transceiver_bulk_status

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Fix issue: #12981

How did you do it?

Skip dom checker for sfp with flat memory

How did you verify/test it?

run test_xcvr_info_in_db and test_check_sfp_eeprom_with_option_dom

Any platform specific information?

Any

Supported testbed topology if it's a new test case?

Documentation

…onic-net#14182)

* update platform tests due to flat memory

Change-Id: I7d285fadc2169bac73b919ec01b0a9914c480c85

* fix error introduced by kvm

* skip test ports with flat memory for test_get_transceiver_bulk_status

* fix test_check_sfp_eeprom_with_option_dom

when port support flat memory, all parameters check related dom should be skipped

* Change the get_map_port_to_start_and_end_line_number_for_sfp_eeprom to get_sfp_eeprom_map_per_port so it is clear and easy to use
@JibinBao
Copy link
Contributor Author

Cherry-pick #14182

@bingwang-ms
Copy link
Collaborator

Retriggered PR testing.

@bingwang-ms bingwang-ms merged commit 4737b47 into sonic-net:202405 Oct 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants