Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Update qos sai tests for spc4 platform #14342

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

JibinBao
Copy link
Contributor

@JibinBao JibinBao commented Aug 30, 2024

Description of PR

  1. update qos sai test for sn5400 refering to the two PRs below
  1. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Update qos sai test for spc4 platform

How did you do it?

  1. update qos sai test for sn5400
  2. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4

How did you verify/test it?

Run qos tests on spc4 platform

Any platform specific information?

spc4

Supported testbed topology if it's a new test case?

Documentation

1. update qos sai test for sn5400 according to the two PRs below

  a.  sonic-net#9583
  b.  sonic-net#12848

2. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4

Change-Id: Ic3919a9123cd968fb9d89013687cf31791684208
@wsycqyz
Copy link
Contributor

wsycqyz commented Sep 2, 2024

@XuChen-MSFT FYI

@bingwang-ms
Copy link
Collaborator

@JibinBao Can you please paste or upload the test result for this change?

@JibinBao
Copy link
Contributor Author

JibinBao commented Oct 15, 2024

@JibinBao Can you please paste or upload the test result for this change?
hi @bingwang-ms , All cases passed on the platforms, please see the picture below:
image

@bingwang-ms
Copy link
Collaborator

@Pterosaur , @Janetxxx Can you help review?

Copy link
Contributor

@Janetxxx Janetxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bingwang-ms bingwang-ms merged commit 359ff0b into sonic-net:master Oct 30, 2024
17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 30, 2024
1. update qos sai test for sn5400 according to the two PRs below

  a.  sonic-net#9583
  b.  sonic-net#12848

2. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4

Change-Id: Ic3919a9123cd968fb9d89013687cf31791684208
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #15284

mssonicbld pushed a commit that referenced this pull request Oct 31, 2024
1. update qos sai test for sn5400 according to the two PRs below

  a.  #9583
  b.  #12848

2. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4

Change-Id: Ic3919a9123cd968fb9d89013687cf31791684208
sreejithsreekumaran pushed a commit to sreejithsreekumaran/sonic-mgmt that referenced this pull request Nov 15, 2024
1. update qos sai test for sn5400 according to the two PRs below

  a.  sonic-net#9583
  b.  sonic-net#12848

2. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4

Change-Id: Ic3919a9123cd968fb9d89013687cf31791684208
yutongzhang-microsoft pushed a commit to yutongzhang-microsoft/sonic-mgmt that referenced this pull request Nov 21, 2024
1. update qos sai test for sn5400 according to the two PRs below

  a.  sonic-net#9583
  b.  sonic-net#12848

2. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4

Change-Id: Ic3919a9123cd968fb9d89013687cf31791684208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants