Fix test_ecmp_hash_seed_value failure on 202311 #13632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 15, 2024
What is the motivation for this PR? Fix test_ecmp_hash_seed_value failure on 202311 fix one function mistake in case. remove internal and master from skip list, internal and master should support this case now How did you do it? Only check if sai_hash_seed_config_hash_offset_enable exists in config.bcm for 202305 branch, will skip this check for other branches. How did you verify/test it? run test_ecmp_sai_value against 202311.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 15, 2024
What is the motivation for this PR? Fix test_ecmp_hash_seed_value failure on 202311 fix one function mistake in case. remove internal and master from skip list, internal and master should support this case now How did you do it? Only check if sai_hash_seed_config_hash_offset_enable exists in config.bcm for 202305 branch, will skip this check for other branches. How did you verify/test it? run test_ecmp_sai_value against 202311.
|
Cherry-pick PR to 202311: #13665 |
|
Cherry-pick PR to 202405: #13666 |
This was referenced Jul 15, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jul 15, 2024
What is the motivation for this PR? Fix test_ecmp_hash_seed_value failure on 202311 fix one function mistake in case. remove internal and master from skip list, internal and master should support this case now How did you do it? Only check if sai_hash_seed_config_hash_offset_enable exists in config.bcm for 202305 branch, will skip this check for other branches. How did you verify/test it? run test_ecmp_sai_value against 202311.
mssonicbld
pushed a commit
that referenced
this pull request
Jul 16, 2024
What is the motivation for this PR? Fix test_ecmp_hash_seed_value failure on 202311 fix one function mistake in case. remove internal and master from skip list, internal and master should support this case now How did you do it? Only check if sai_hash_seed_config_hash_offset_enable exists in config.bcm for 202305 branch, will skip this check for other branches. How did you verify/test it? run test_ecmp_sai_value against 202311.
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? Fix test_ecmp_hash_seed_value failure on 202311 fix one function mistake in case. remove internal and master from skip list, internal and master should support this case now How did you do it? Only check if sai_hash_seed_config_hash_offset_enable exists in config.bcm for 202305 branch, will skip this check for other branches. How did you verify/test it? run test_ecmp_sai_value against 202311.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
After code change sonic-net/sonic-buildimage#18912 and #13538, test_ecmp_sai_value is not xfailed on 202311, but test_ecmp_hash_seed_value consistently failed on 202311, since the sai_hash_seed_config_hash_offset_enable is not set in config.bcm, it's set by swss config on 202311 and later image.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
Only check if sai_hash_seed_config_hash_offset_enable exists in config.bcm for 202305 branch, will skip this check for other branches.
How did you verify/test it?
run test_ecmp_sai_value against 202311.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation