-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API #11708
Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API #11708
Conversation
…are_versions API Signed-off-by: Mihir Patel <patelmi@microsoft.com>
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
@mihirpat1 please see if master buildimage has the code changes to support this test PR |
Confirmed that the master buildimage has the required code changes via |
@StormLiangMS @yxieca - Can you please help to cherry-pick this to 202205, 202305 and 202311? |
…are_versions API (sonic-net#11708) * Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Addressed pre-commit check issues --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Cherry-pick PR to 202311: #11749 |
…are_versions API (#11708) * Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Addressed pre-commit check issues --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
…are_versions API (sonic-net#11708) * Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Addressed pre-commit check issues --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Cherry-pick PR to 202305: #11918 |
…are_versions API (#11708) * Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Addressed pre-commit check issues --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Description of PR
Since we are now planning to remove "active_firmware" and "inactive_firmware" version fields from TRANSCEIVER_INFO and are replacing it with TRANSCEIVER_FIRMWARE_INFO, we need to add a testcase for get_transceiver_info_firmware_versions API.
Also, we need to remove these fields from the existing testcase for
sonic-mgmt/tests/platform_tests/api/test_sfp.py
Line 373 in aba8a1c
MSFT ADO - 26818128
Summary:
Fixes # (issue)
This issue should be merged along with sonic-net/sonic-platform-daemons#435 and sonic-net/sonic-platform-common#440
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Ensured that platform_tests/api/test_sfp.py::TestSfpApi::test_get_transceiver_info testcase passes for a CMIS supported transceiver.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation