-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to render template format of delayed
flag on Feature Table.
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Table. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@mlok-nokia @anamehra for viz. |
mlok-nokia
approved these changes
Jul 5, 2024
anamehra
approved these changes
Jul 5, 2024
yejianquan
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mssonicbld
pushed a commit
to mssonicbld/sonic-host-services
that referenced
this pull request
Jul 9, 2024
…Table. (sonic-net#135) What I did: Added support to render template format of delayed flag on Feature Table. Why I did: To fix: sonic-net/sonic-buildimage#19126 How I verify: Manual Verification UT updated Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Cherry-pick PR to 202405: #137 |
abdosi
pushed a commit
that referenced
this pull request
Jul 11, 2024
…Table. (#135) (#137) What I did: Added support to render template format of delayed flag on Feature Table. Why I did: To fix: sonic-net/sonic-buildimage#19126 How I verify: Manual Verification UT updated Signed-off-by: Abhishek Dosi abdosi@microsoft.com
11 tasks
Added tag as #137 has been merged to 202405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added support to render template format of
delayed
flag on Feature Table.Why I did:
To fix: sonic-net/sonic-buildimage#19126
How I verify:
Manual Verification
UT updated