-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransL Bulk API enhancement #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Modified transl's Bulk processing API to support new translib Bulk API
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
hdwhdw
approved these changes
Feb 19, 2025
@liuh-80 please rebase sonic-mgmt-common repo and re-try the build. Your
repo does not seem to have
sonic-net/sonic-mgmt-common#118
…On Wed, Feb 26, 2025 at 2:46 PM Hua Liu ***@***.***> wrote:
@faraazbrcm <https://github.com/faraazbrcm> ,can you check your PR? when
I update submodule with latest buildimage repo, get following error:
github.com/sonic-net/sonic-gnmi/transl_utils
transl_utils/transl_utils.go:342:28: undefined: translib.BulkRequestEntry
transl_utils/transl_utils.go:347:26: br.Request undefined (type
translib.BulkRequest has no field or method Request)
transl_utils/transl_utils.go:362:28: undefined: translib.BulkRequestEntry
transl_utils/transl_utils.go:367:26: br.Request undefined (type
translib.BulkRequest has no field or method Request)
transl_utils/transl_utils.go:381:28: undefined: translib.BulkRequestEntry
transl_utils/transl_utils.go:386:26: br.Request undefined (type
translib.BulkRequest has no field or method Request)
transl_utils/transl_utils.go:391:22: resp.Response undefined (type
translib.BulkResponse has no field or method Response)
transl_utils/transl_utils.go:392:43: resp.Response undefined (type
translib.BulkResponse has no field or method Response)
transl_utils/transl_utils.go:392:70: br.Request undefined (type
translib.BulkRequest has no field or method Request)
transl_utils/transl_utils.go:392:98: resp.Response undefined (type
translib.BulkResponse has no field or method Response)
transl_utils/transl_utils.go:392:98: too many errors
Here is my PR:
sonic-net/sonic-buildimage#21861
<sonic-net/sonic-buildimage#21861>
—
Reply to this email directly, view it on GitHub
<#364 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMN6I5OKOFAIMH3T3IM67JD2RWA6DAVCNFSM6AAAAABXOSYMOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBUGM3TGNBQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: liuh-80]*liuh-80* left a comment (sonic-net/sonic-gnmi#364)
<#364 (comment)>
@faraazbrcm <https://github.com/faraazbrcm> ,can you check your PR? when
I update submodule with latest buildimage repo, get following error:
github.com/sonic-net/sonic-gnmi/transl_utils
transl_utils/transl_utils.go:342:28: undefined: translib.BulkRequestEntry
transl_utils/transl_utils.go:347:26: br.Request undefined (type
translib.BulkRequest has no field or method Request)
transl_utils/transl_utils.go:362:28: undefined: translib.BulkRequestEntry
transl_utils/transl_utils.go:367:26: br.Request undefined (type
translib.BulkRequest has no field or method Request)
transl_utils/transl_utils.go:381:28: undefined: translib.BulkRequestEntry
transl_utils/transl_utils.go:386:26: br.Request undefined (type
translib.BulkRequest has no field or method Request)
transl_utils/transl_utils.go:391:22: resp.Response undefined (type
translib.BulkResponse has no field or method Response)
transl_utils/transl_utils.go:392:43: resp.Response undefined (type
translib.BulkResponse has no field or method Response)
transl_utils/transl_utils.go:392:70: br.Request undefined (type
translib.BulkRequest has no field or method Request)
transl_utils/transl_utils.go:392:98: resp.Response undefined (type
translib.BulkResponse has no field or method Response)
transl_utils/transl_utils.go:392:98: too many errors
Here is my PR:
sonic-net/sonic-buildimage#21861
<sonic-net/sonic-buildimage#21861>
—
Reply to this email directly, view it on GitHub
<#364 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMN6I5OKOFAIMH3T3IM67JD2RWA6DAVCNFSM6AAAAABXOSYMOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBUGM3TGNBQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Thanks and Regards
Faraaz
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified transl's Bulk processing API to support new translib Bulk API
Why I did it
The Translib API for bulk operations in sonic-mgmt-common has been updated for gNMI conformance. This pull request modifies the sonic-gnmi Bulk API to ensure compliance with these changes.
How I did it
Modified transl_utils' processBulkAPI
How to verify it
Verified by making gNMI bulk request