Use the latest libswsscommon artifacts from the repo #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For libswsscommon, instead of getting the artifacts from the sonic-buildimage repo, get it from the sonic-swss-common repo instead. The version in sonic-buildimage might be behind because the submodule update hasn't happened. That way, it's testing with the latest code, and also matches the go compilation where it uses the latest of sonic-swss-common. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
ganglyu
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
For libswsscommon, instead of getting the artifacts from the sonic-buildimage repo, get it from the sonic-swss-common repo instead. The version in sonic-buildimage might be behind because the submodule update hasn't happened. That way, it's testing with the latest code, and also matches the go compilation where it uses the latest of sonic-swss-common.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)