re-enable unit test

sonic-net · May 7, 2024 · b08ce09 · b08ce09
1 parent 427c6f9
commit b08ce09
Showing 1 changed file with 23 additions and 23 deletions.
diff --git a/gnmi_server/server_test.go b/gnmi_server/server_test.go
@@ -24,7 +24,7 @@ import (
 	sgpb "github.com/sonic-net/sonic-gnmi/proto/gnoi"
 	sdc "github.com/sonic-net/sonic-gnmi/sonic_data_client"
 	sdcfg "github.com/sonic-net/sonic-gnmi/sonic_db_config"
-	// ssc "github.com/sonic-net/sonic-gnmi/sonic_service_client"
+	ssc "github.com/sonic-net/sonic-gnmi/sonic_service_client"
 	"github.com/sonic-net/sonic-gnmi/test_utils"
 	testcert "github.com/sonic-net/sonic-gnmi/testdata/tls"
 
@@ -4164,28 +4164,28 @@ func TestMasterArbitration(t *testing.T) {
 	})
 }
 
-// func TestSaveOnSet(t *testing.T) {
-// 	// Fail client creation
-// 	fakeDBC := gomonkey.ApplyFuncReturn(ssc.NewDbusClient, nil, fmt.Errorf("Fail Create"))
-// 	if err := SaveOnSetEnabled(); err == nil {
-// 		t.Error("Expected Client Failure")
-// 	}
-// 	fakeDBC.Reset()
-
-// 	// Successful Dbus call
-// 	goodDbus := gomonkey.ApplyFuncReturn(ssc.DbusApi, nil)
-// 	if err := SaveOnSetEnabled(); err != nil {
-// 		t.Error("Unexpected DBUS failure")
-// 	}
-// 	goodDbus.Reset()
-
-// 	// Fail Dbus call
-// 	badDbus := gomonkey.ApplyFuncReturn(ssc.DbusApi, fmt.Errorf("Fail Send"))
-// 	defer badDbus.Reset()
-// 	if err := SaveOnSetEnabled(); err == nil {
-// 		t.Error("Expected DBUS failure")
-// 	}
-// }
+func TestSaveOnSet(t *testing.T) {
+	// Fail client creation
+	fakeDBC := gomonkey.ApplyFuncReturn(ssc.NewDbusClient, nil, fmt.Errorf("Fail Create"))
+	if err := SaveOnSetEnabled(); err == nil {
+		t.Error("Expected Client Failure")
+	}
+	fakeDBC.Reset()
+
+	// Successful Dbus call
+	goodDbus := gomonkey.ApplyFuncReturn(ssc.DbusApi, nil)
+	if err := SaveOnSetEnabled(); err != nil {
+		t.Error("Unexpected DBUS failure")
+	}
+	goodDbus.Reset()
+
+	// Fail Dbus call
+	badDbus := gomonkey.ApplyFuncReturn(ssc.DbusApi, fmt.Errorf("Fail Send"))
+	defer badDbus.Reset()
+	if err := SaveOnSetEnabled(); err == nil {
+		t.Error("Expected DBUS failure")
+	}
+}
 
 func init() {
 	// Enable logs at UT setup